From: Thomas Huth <thuth@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org,
Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org, Collin Walling <walling@linux.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v1 for-2.13 2/4] pc-bios/s390-ccw/net: Stop virtio-net device before jumping into the OS
Date: Fri, 20 Apr 2018 08:31:16 +0200 [thread overview]
Message-ID: <7ebf0874-1b70-47e4-fce6-15566887270f@redhat.com> (raw)
In-Reply-To: <0be89209-6ee5-2f12-fae2-21709fcf6f8a@de.ibm.com>
On 19.04.2018 17:49, Christian Borntraeger wrote:
> On 04/18/2018 02:31 PM, Thomas Huth wrote:
>> The virtio-net receive buffers are filled asynchronously, so we should
>> make sure to properly shut down the virtio-net device before we jump into
>> the loaded kernel. Otherwise an incoming packet could destroy memory of
>> the OS kernel if it did not re-initialize the virtio-net device fast
>> enough yet.
>
> The normal bios does a full subsystem reset before we enter the OS.
> (see jump_to_IPL_code the diag 308). That should reset all virtio
> devices on the qemu level. Shouldnt we rather do the same for
> the net bios?
That should fix this issue, too, right. I'll give it a try and include
it in v2 if I can make it work...
Thomas
next prev parent reply other threads:[~2018-04-20 6:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 12:31 [Qemu-devel] [PATCH v1 for-2.13 0/4] pc-bios/s390-ccw: Network boot improvements Thomas Huth
2018-04-18 12:31 ` [Qemu-devel] [PATCH v1 for-2.13 1/4] pc-bios/s390-ccw/net: Split up net_load() into init, load and uninit parts Thomas Huth
2018-04-18 18:11 ` Farhan Ali
2018-04-19 5:20 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-04-18 12:31 ` [Qemu-devel] [PATCH v1 for-2.13 2/4] pc-bios/s390-ccw/net: Stop virtio-net device before jumping into the OS Thomas Huth
2018-04-19 15:49 ` Christian Borntraeger
2018-04-20 6:31 ` Thomas Huth [this message]
2018-04-20 7:25 ` Christian Borntraeger
2018-04-18 12:31 ` [Qemu-devel] [PATCH v1 for-2.13 3/4] pc-bios/s390-ccw/net: Add support for pxelinux-style config files Thomas Huth
2018-04-19 7:41 ` Viktor VM Mihajlovski
2018-04-19 8:17 ` Thomas Huth
2018-04-19 12:40 ` Viktor VM Mihajlovski
2018-04-19 16:55 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-04-20 6:53 ` Viktor VM Mihajlovski
2018-04-20 7:36 ` Thomas Huth
2018-04-20 7:54 ` Viktor VM Mihajlovski
2018-04-20 8:40 ` Thomas Huth
2018-04-20 12:11 ` Viktor VM Mihajlovski
2018-04-18 12:31 ` [Qemu-devel] [PATCH v1 for-2.13 4/4] pc-bios/s390-ccw/net: Add support for .INS " Thomas Huth
2018-04-19 8:02 ` Viktor VM Mihajlovski
2018-04-19 8:20 ` Thomas Huth
2018-04-18 18:21 ` [Qemu-devel] [PATCH v1 for-2.13 0/4] pc-bios/s390-ccw: Network boot improvements Farhan Ali
2018-04-19 5:27 ` [Qemu-devel] [qemu-s390x] " Thomas Huth
2018-04-19 12:03 ` Farhan Ali
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ebf0874-1b70-47e4-fce6-15566887270f@redhat.com \
--to=thuth@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=walling@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).