[Qemu-devel] [PATCH] MAINTAINERS: Add some missing SPARC-related files

[Qemu-devel] [PATCH] MAINTAINERS: Add some missing SPARC-related files

[Thomas Huth]

These files / devices are only used by SPARC machines, so we can sort
them into the corresponding categories in the MAINTAINERS file.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 MAINTAINERS | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index b6c2645..e897963 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1069,9 +1069,11 @@ M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
 S: Maintained
 F: hw/sparc/sun4m.c
 F: hw/sparc/sun4m_iommu.c
+F: hw/display/cg3.c
+F: hw/display/tcx.c
 F: hw/dma/sparc32_dma.c
 F: hw/misc/eccmemctl.c
-F: hw/misc/slavio_misc.c
+F: hw/*/slavio_*.c
 F: include/hw/sparc/sparc32_dma.h
 F: pc-bios/openbios-sparc32
 F: include/hw/sparc/sun4m_iommu.h
@@ -1083,6 +1085,8 @@ F: hw/sparc64/sun4u.c
 F: pc-bios/openbios-sparc64
 F: hw/pci-host/sabre.c
 F: include/hw/pci-host/sabre.h
+F: include/hw/sparc/sun4u_iommu.h
+F: include/hw/nvram/sun_nvram.h
 
 Sun4v
 M: Artyom Tarasenko <atar4qemu@gmail.com>
-- 
1.8.3.1

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some missing SPARC-related files

[Philippe Mathieu-Daudé]

Hi Thomas,

On 1/2/19 4:46 PM, Thomas Huth wrote:
> These files / devices are only used by SPARC machines, so we can sort
> them into the corresponding categories in the MAINTAINERS file.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  MAINTAINERS | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b6c2645..e897963 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1069,9 +1069,11 @@ M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>  S: Maintained
>  F: hw/sparc/sun4m.c
>  F: hw/sparc/sun4m_iommu.c
> +F: hw/display/cg3.c
> +F: hw/display/tcx.c
>  F: hw/dma/sparc32_dma.c
>  F: hw/misc/eccmemctl.c
> -F: hw/misc/slavio_misc.c
> +F: hw/*/slavio_*.c
>  F: include/hw/sparc/sparc32_dma.h
>  F: pc-bios/openbios-sparc32
>  F: include/hw/sparc/sun4m_iommu.h
> @@ -1083,6 +1085,8 @@ F: hw/sparc64/sun4u.c
>  F: pc-bios/openbios-sparc64
>  F: hw/pci-host/sabre.c
>  F: include/hw/pci-host/sabre.h
> +F: include/hw/sparc/sun4u_iommu.h

I sent a patch to trivial@ with other sun4u changes, reviewed by Mark:
https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04467.html

Neither mine nor your are complete :)
Can I include your patch when respining the series? (Not sure I need to
respin although).

> +F: include/hw/nvram/sun_nvram.h

sun_nvram.h is also used by sun4m (the previous section this patch updates).

>  
>  Sun4v
>  M: Artyom Tarasenko <atar4qemu@gmail.com>
> 

Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some missing SPARC-related files

[Thomas Huth]

On 2019-01-02 20:34, Philippe Mathieu-Daudé wrote:
> Hi Thomas,
> 
> On 1/2/19 4:46 PM, Thomas Huth wrote:
>> These files / devices are only used by SPARC machines, so we can sort
>> them into the corresponding categories in the MAINTAINERS file.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>> ---
>>  MAINTAINERS | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b6c2645..e897963 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -1069,9 +1069,11 @@ M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>  S: Maintained
>>  F: hw/sparc/sun4m.c
>>  F: hw/sparc/sun4m_iommu.c
>> +F: hw/display/cg3.c
>> +F: hw/display/tcx.c
>>  F: hw/dma/sparc32_dma.c
>>  F: hw/misc/eccmemctl.c
>> -F: hw/misc/slavio_misc.c
>> +F: hw/*/slavio_*.c
>>  F: include/hw/sparc/sparc32_dma.h
>>  F: pc-bios/openbios-sparc32
>>  F: include/hw/sparc/sun4m_iommu.h
>> @@ -1083,6 +1085,8 @@ F: hw/sparc64/sun4u.c
>>  F: pc-bios/openbios-sparc64
>>  F: hw/pci-host/sabre.c
>>  F: include/hw/pci-host/sabre.h
>> +F: include/hw/sparc/sun4u_iommu.h
> 
> I sent a patch to trivial@ with other sun4u changes, reviewed by Mark:
> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04467.html

Oh, right, sorry!

> Neither mine nor your are complete :)
> Can I include your patch when respining the series? (Not sure I need to
> respin although).

Sure!

>> +F: include/hw/nvram/sun_nvram.h
> 
> sun_nvram.h is also used by sun4m (the previous section this patch updates).

Right. So it should maybe be listed twice... (but since the maintainer
of sun4u and sun4m is the same, it likely does not really matter)

 Thomas

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some missing SPARC-related files

[Mark Cave-Ayland]

On 03/01/2019 07:19, Thomas Huth wrote:
> On 2019-01-02 20:34, Philippe Mathieu-Daudé wrote:
>> Hi Thomas,
>>
>> On 1/2/19 4:46 PM, Thomas Huth wrote:
>>> These files / devices are only used by SPARC machines, so we can sort
>>> them into the corresponding categories in the MAINTAINERS file.
>>>
>>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>>> ---
>>>  MAINTAINERS | 6 +++++-
>>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index b6c2645..e897963 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -1069,9 +1069,11 @@ M: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>>  S: Maintained
>>>  F: hw/sparc/sun4m.c
>>>  F: hw/sparc/sun4m_iommu.c
>>> +F: hw/display/cg3.c
>>> +F: hw/display/tcx.c
>>>  F: hw/dma/sparc32_dma.c
>>>  F: hw/misc/eccmemctl.c
>>> -F: hw/misc/slavio_misc.c
>>> +F: hw/*/slavio_*.c
>>>  F: include/hw/sparc/sparc32_dma.h
>>>  F: pc-bios/openbios-sparc32
>>>  F: include/hw/sparc/sun4m_iommu.h
>>> @@ -1083,6 +1085,8 @@ F: hw/sparc64/sun4u.c
>>>  F: pc-bios/openbios-sparc64
>>>  F: hw/pci-host/sabre.c
>>>  F: include/hw/pci-host/sabre.h
>>> +F: include/hw/sparc/sun4u_iommu.h
>>
>> I sent a patch to trivial@ with other sun4u changes, reviewed by Mark:
>> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04467.html
> 
> Oh, right, sorry!
> 
>> Neither mine nor your are complete :)
>> Can I include your patch when respining the series? (Not sure I need to
>> respin although).
> 
> Sure!

Certainly these extra files look correct to me - Philippe, I think I already gave R-B
tags for these, so feel free to keep them when you re-post the series with Thomas's
changes.


ATB,

Mark.

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add some missing SPARC-related files

[Philippe Mathieu-Daudé]

On 1/3/19 8:19 AM, Thomas Huth wrote:
> On 2019-01-02 20:34, Philippe Mathieu-Daudé wrote:
[...]
>> I sent a patch to trivial@ with other sun4u changes, reviewed by Mark:
>> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04467.html
> 
> Oh, right, sorry!
> 
>> Neither mine nor your are complete :)
>> Can I include your patch when respining the series? (Not sure I need to
>> respin although).
> 
> Sure!

Thanks :)

> 
>>> +F: include/hw/nvram/sun_nvram.h
>>
>> sun_nvram.h is also used by sun4m (the previous section this patch updates).
> 
> Right. So it should maybe be listed twice... (but since the maintainer
> of sun4u and sun4m is the same, it likely does not really matter)

Yes, this is true as of today, but maybe tomorrow the current maintainer
will give over one of these sections to someone else...