From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Alexander Graf <agraf@suse.de>,
Anthony Liguori <aliguori@us.ibm.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
kvm@vger.kernel.org, "Michael S. Tsirkin" <mst@redhat.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
Riku Voipio <riku.voipio@iki.fi>, Christoph Hellwig <hch@lst.de>,
Blue Swirl <blauwirbel@gmail.com>,
Alex Williamson <alex.williamson@redhat.com>,
Isaku Yamahata <yamahata@valinux.co.jp>,
Paul Brook <paul@codesourcery.com>,
Paolo Bonzini <pbonzini@redhat.com>, Avi Kivity <avi@redhat.com>,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH 03/10] usb-ehci: remove unused variables
Date: Tue, 14 Jun 2011 20:35:36 +0300 [thread overview]
Message-ID: <7ec91cd83a2f953892e91bd69d23fbe233e09c11.1308072799.git.mst@redhat.com> (raw)
In-Reply-To: <cover.1308072799.git.mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/usb-ehci.c | 10 +---------
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c
index 4d6989a..c20ee22 100644
--- a/hw/usb-ehci.c
+++ b/hw/usb-ehci.c
@@ -523,11 +523,8 @@ static void ehci_detach(USBPort *port)
static void ehci_reset(void *opaque)
{
EHCIState *s = opaque;
- uint8_t *pci_conf;
int i;
- pci_conf = s->dev.config;
-
memset(&s->mmio[OPREGBASE], 0x00, MMIO_SIZE - OPREGBASE);
s->usbcmd = NB_MAXINTRATE << USBCMD_ITC_SH;
@@ -1105,18 +1102,15 @@ static int ehci_process_itd(EHCIState *ehci,
int ret;
int i, j;
int ptr;
- int pid;
int pg;
int len;
int dir;
int devadr;
int endp;
- int maxpkt;
dir =(itd->bufptr[1] & ITD_BUFPTR_DIRECTION);
devadr = get_field(itd->bufptr[0], ITD_BUFPTR_DEVADDR);
endp = get_field(itd->bufptr[0], ITD_BUFPTR_EP);
- maxpkt = get_field(itd->bufptr[1], ITD_BUFPTR_MAXPKT);
for(i = 0; i < 8; i++) {
if (itd->transact[i] & ITD_XACT_ACTIVE) {
@@ -1136,9 +1130,7 @@ static int ehci_process_itd(EHCIState *ehci,
if (!dir) {
cpu_physical_memory_rw(ptr, &ehci->buffer[0], len, 0);
- pid = USB_TOKEN_OUT;
- } else
- pid = USB_TOKEN_IN;
+ }
ret = USB_RET_NODEV;
--
1.7.5.53.gc233e
next prev parent reply other threads:[~2011-06-14 17:35 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-14 17:35 [Qemu-devel] [PATCH 00/10] qemu: remove set but unused variables Michael S. Tsirkin
2011-06-14 17:35 ` [Qemu-devel] [PATCH 01/10] ppce500: move device/vendor/class id to qdev Michael S. Tsirkin
2011-06-14 22:42 ` Isaku Yamahata
2011-06-14 17:35 ` [Qemu-devel] [PATCH 02/10] usb-ehci: " Michael S. Tsirkin
2011-06-14 17:35 ` Michael S. Tsirkin [this message]
2011-06-15 6:45 ` [Qemu-devel] [PATCH 03/10] usb-ehci: remove unused variables Gerd Hoffmann
2011-06-14 17:35 ` [Qemu-devel] [PATCH 04/10] lsi53c895a: " Michael S. Tsirkin
2011-06-15 9:23 ` Stefan Hajnoczi
2011-06-14 17:35 ` [Qemu-devel] [PATCH 05/10] wdt: " Michael S. Tsirkin
2011-06-14 22:47 ` Isaku Yamahata
2011-06-14 17:36 ` [Qemu-devel] [PATCH 06/10] kvm: " Michael S. Tsirkin
2011-06-15 7:38 ` Kevin Wolf
2011-06-15 8:25 ` Michael S. Tsirkin
2011-06-15 8:42 ` Jan Kiszka
2011-06-15 12:44 ` Chris Krumme
2011-06-15 18:29 ` Michael S. Tsirkin
2011-06-14 17:36 ` [Qemu-devel] [PATCH 07/10] alpha/translate: remve " Michael S. Tsirkin
2011-06-14 17:47 ` Richard Henderson
2011-06-14 17:36 ` [Qemu-devel] [PATCH 08/10] alpha: remove unused variable Michael S. Tsirkin
2011-06-14 17:47 ` Richard Henderson
2011-06-23 11:47 ` Peter Maydell
2011-06-23 15:25 ` Richard Henderson
2011-06-14 17:36 ` [Qemu-devel] [PATCH 09/10] exec: " Michael S. Tsirkin
2011-06-26 11:08 ` Michael S. Tsirkin
2011-06-26 14:32 ` Stefan Hajnoczi
2011-06-14 17:36 ` [Qemu-devel] [PATCH 10/10] linux-user: remove unused variables Michael S. Tsirkin
2011-06-15 8:35 ` Alexander Graf
2011-06-15 8:55 ` Michael S. Tsirkin
2011-06-15 14:32 ` Richard Henderson
2011-06-15 18:40 ` Michael S. Tsirkin
2011-06-15 16:51 ` Peter Maydell
2011-06-26 11:11 ` Michael S. Tsirkin
2011-06-27 9:06 ` Peter Maydell
2011-06-27 9:13 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ec91cd83a2f953892e91bd69d23fbe233e09c11.1308072799.git.mst@redhat.com \
--to=mst@redhat.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=hch@lst.de \
--cc=jan.kiszka@siemens.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=mtosatti@redhat.com \
--cc=paul@codesourcery.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
--cc=stefanha@linux.vnet.ibm.com \
--cc=yamahata@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).