qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Daniel Henrique Barboza <danielhb413@gmail.com>
Cc: Kewen Lin <linkw@linux.ibm.com>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	John Platts <john_platts@hotmail.com>,
	Fabiano Rosas <farosas@linux.ibm.com>
Subject: Re: [PATCH v2] tests/tcg: Replace -mpower8-vector with -mcpu=power8
Date: Wed, 23 Oct 2024 09:20:57 -0700	[thread overview]
Message-ID: <7ece7f8b-652f-4e76-9e77-ababd729717d@linaro.org> (raw)
In-Reply-To: <20241023131250.48510-1-iii@linux.ibm.com>

On 10/23/24 06:12, Ilya Leoshkevich wrote:
> [1] deprecated -mpower8-vector, resulting in:
> 
>      powerpc64-linux-gnu-gcc: warning: switch '-mpower8-vector' is no longer supported
>      qemu/tests/tcg/ppc64/vsx_f2i_nan.c:4:15: error: expected ';' before 'float'
>          4 | typedef vector float vsx_float32_vec_t;
>            |               ^~~~~~
> 
> Use -mcpu=power8 instead. In order to properly verify that this works,
> one needs a big-endian (the minimum supported CPU for 64-bit
> little-endian is power8 anyway) GCC configured with --enable-checking
> (see GCC commit e154242724b0 ("[RS6000] Don't pass -many to the
> assembler").
> 
> [1]https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109987
> 
> Signed-off-by: Ilya Leoshkevich<iii@linux.ibm.com>
> ---
> v1:https://lore.kernel.org/qemu-devel/20241021142830.486149-1-iii@linux.ibm.com/
> v1 -> v2: Use -mcpu=power8 instead of -mvsx (Richard).
> 
>   tests/tcg/ppc64/Makefile.target | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~


  reply	other threads:[~2024-10-23 16:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 13:12 [PATCH v2] tests/tcg: Replace -mpower8-vector with -mcpu=power8 Ilya Leoshkevich
2024-10-23 16:20 ` Richard Henderson [this message]
2024-10-23 19:55 ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ece7f8b-652f-4e76-9e77-ababd729717d@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=danielhb413@gmail.com \
    --cc=farosas@linux.ibm.com \
    --cc=iii@linux.ibm.com \
    --cc=john_platts@hotmail.com \
    --cc=linkw@linux.ibm.com \
    --cc=npiggin@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).