From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Andrew Jones" <drjones@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Pierre Morel" <pmorel@linux.ibm.com>,
"Pankaj Gupta" <pankaj.gupta.linux@gmail.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
qemu-devel@nongnu.org, "Yanan Wang" <wangyanan55@huawei.com>,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
wanghaibin.wang@huawei.com,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v12 16/16] machine: Make smp_parse return a boolean
Date: Thu, 7 Oct 2021 10:29:34 +0200 [thread overview]
Message-ID: <7ecf30ae-9fdb-2fec-de0f-c542b51cbbb7@redhat.com> (raw)
In-Reply-To: <87bl47ll9l.fsf@dusky.pond.sub.org>
On 02/10/21 13:27, Markus Armbruster wrote:
>> The "return a boolean" rule adds some complexity (and
>> a possibility for things to be wrong/inconsistent) to the function for
>> the benefit of the callers.
> Yes, but returning something is only a minor burden. It also makes
> success vs. failure obvious at a glance.
Fair enough; I'd still prefer to have an exception to the rule for
virtual functions. In that case, I really find the benefit to be negative.
Paolo
next prev parent reply other threads:[~2021-10-07 8:32 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 2:58 [PATCH v12 00/16] machine: smp parsing fixes and improvement Yanan Wang
2021-09-29 2:58 ` [PATCH v12 01/16] qapi/machine: Fix an incorrect comment of SMPConfiguration Yanan Wang
2021-09-29 2:58 ` [PATCH v12 02/16] machine: Deprecate "parameter=0" SMP configurations Yanan Wang
2021-09-29 2:58 ` [PATCH v12 03/16] machine: Minor refactor/fix for the smp parsers Yanan Wang
2021-09-29 2:58 ` [PATCH v12 04/16] machine: Uniformly use maxcpus to calculate the omitted parameters Yanan Wang
2021-09-29 2:58 ` [PATCH v12 05/16] machine: Set the value of cpus to match maxcpus if it's omitted Yanan Wang
2021-09-29 2:58 ` [PATCH v12 06/16] machine: Improve the error reporting of smp parsing Yanan Wang
2021-09-29 2:58 ` [PATCH v12 07/16] qtest/numa-test: Use detailed -smp CLIs in pc_dynamic_cpu_cfg Yanan Wang
2021-09-29 2:58 ` [PATCH v12 08/16] qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split Yanan Wang
2021-09-29 2:58 ` [PATCH v12 09/16] machine: Prefer cores over sockets in smp parsing since 6.2 Yanan Wang
2021-09-29 2:58 ` [PATCH v12 10/16] machine: Use ms instead of global current_machine in sanity-check Yanan Wang
2021-09-29 2:58 ` [PATCH v12 11/16] machine: Tweak the order of topology members in struct CpuTopology Yanan Wang
2021-09-29 2:58 ` [PATCH v12 12/16] machine: Make smp_parse generic enough for all arches Yanan Wang
2021-09-29 2:58 ` [PATCH v12 13/16] machine: Remove smp_parse callback from MachineClass Yanan Wang
2021-09-29 2:58 ` [PATCH v12 14/16] machine: Move smp_prefer_sockets to struct SMPCompatProps Yanan Wang
2021-09-29 2:58 ` [PATCH v12 15/16] machine: Put all sanity-check in the generic SMP parser Yanan Wang
2021-09-29 2:58 ` [PATCH v12 16/16] machine: Make smp_parse return a boolean Yanan Wang
2021-09-29 8:27 ` Philippe Mathieu-Daudé
2021-09-29 8:28 ` Daniel P. Berrangé
2021-09-29 11:22 ` Markus Armbruster
2021-10-01 17:08 ` Paolo Bonzini
2021-10-01 17:15 ` Daniel P. Berrangé
2021-10-02 5:26 ` Markus Armbruster
2021-10-02 6:40 ` Paolo Bonzini
2021-10-02 11:27 ` Markus Armbruster
2021-10-07 3:44 ` wangyanan (Y)
2021-10-07 8:30 ` Paolo Bonzini
2021-10-07 8:29 ` Paolo Bonzini [this message]
2021-10-07 12:03 ` Markus Armbruster
2021-09-29 12:39 ` [PATCH v12 00/16] machine: smp parsing fixes and improvement Paolo Bonzini
2021-09-29 14:46 ` Markus Armbruster
2021-09-29 14:57 ` Paolo Bonzini
2021-09-30 1:02 ` wangyanan (Y)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ecf30ae-9fdb-2fec-de0f-c542b51cbbb7@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=drjones@redhat.com \
--cc=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pankaj.gupta.linux@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=pmorel@linux.ibm.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=wanghaibin.wang@huawei.com \
--cc=wangyanan55@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).