From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: "Jamin Lin" <jamin_lin@aspeedtech.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>, "Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: troy_lee@aspeedtech.com, yunlin.tang@aspeedtech.com
Subject: Re: [PATCH v2 5/6] hw/gpio/aspeed: Add AST2700 support
Date: Thu, 26 Sep 2024 13:38:34 +0930 [thread overview]
Message-ID: <7ee6367997fa5f56d14f653b2ac90863f52f1b2f.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240925033454.4117445-6-jamin_lin@aspeedtech.com>
On Wed, 2024-09-25 at 11:34 +0800, Jamin Lin wrote:
>
> + /* interrupt status */
> + if (SHARED_FIELD_EX32(data, GPIO_CONTROL_INT_STATUS)) {
> + pending = extract32(set->int_status, pin_idx, 1);
> + if (pending) {
> + if (s->pending) {
> + assert(s->pending >= pending);
> + s->pending -= pending;
> + }
> + set->int_status = deposit32(set->int_status, pin_idx, 1, 0);
> + }
> + }
I think you can apply the same reasoning here as on the previous patch.
Andrew
next prev parent reply other threads:[~2024-09-26 4:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 3:34 [PATCH v2 0/6] Support GPIO for AST2700 Jamin Lin via
2024-09-25 3:34 ` [PATCH v2 1/6] hw/gpio/aspeed: Fix coding style Jamin Lin via
2024-09-25 3:34 ` [PATCH v2 2/6] hw/gpio/aspeed: Support to set the different memory size Jamin Lin via
2024-09-25 3:34 ` [PATCH v2 3/6] hw/gpio/aspeed: Support different memory region ops Jamin Lin via
2024-09-25 3:34 ` [PATCH v2 4/6] hw/gpio/aspeed: Fix clear incorrect interrupt status for GPIO index mode Jamin Lin via
2024-09-26 4:06 ` Andrew Jeffery
2024-09-26 5:05 ` Jamin Lin
2024-09-25 3:34 ` [PATCH v2 5/6] hw/gpio/aspeed: Add AST2700 support Jamin Lin via
2024-09-26 4:08 ` Andrew Jeffery [this message]
2024-09-26 5:06 ` Jamin Lin
2024-09-25 3:34 ` [PATCH v2 6/6] aspeed/soc: Support GPIO for AST2700 Jamin Lin via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ee6367997fa5f56d14f653b2ac90863f52f1b2f.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
--cc=yunlin.tang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).