From: Stefan Berger <stefanb@linux.ibm.com>
To: P J P <ppandit@redhat.com>, Qemu Developers <qemu-devel@nongnu.org>
Cc: Prasad J Pandit <pjp@fedoraproject.org>,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] tpm: use loop iterator to set sts data field
Date: Tue, 6 Nov 2018 09:26:02 -0500 [thread overview]
Message-ID: <7ef2e233-8413-8055-4282-4e6c46b2fa36@linux.ibm.com> (raw)
In-Reply-To: <20181106052144.31841-2-ppandit@redhat.com>
On 11/6/18 12:21 AM, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> When TIS request is done, set 'sts' data field across all localities.
>
> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
> ---
> hw/tpm/tpm_tis.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
> index 20126dd838..58d90645bc 100644
> --- a/hw/tpm/tpm_tis.c
> +++ b/hw/tpm/tpm_tis.c
> @@ -299,7 +299,7 @@ static void tpm_tis_request_completed(TPMIf *ti, int ret)
>
> if (s->cmd.selftest_done) {
> for (l = 0; l < TPM_TIS_NUM_LOCALITIES; l++) {
> - s->loc[locty].sts |= TPM_TIS_STS_SELFTEST_DONE;
> + s->loc[l].sts |= TPM_TIS_STS_SELFTEST_DONE;
> }
> }
>
next prev parent reply other threads:[~2018-11-06 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 5:21 [Qemu-devel] [PATCH 1/2] tpm: check localities index P J P
2018-11-06 5:21 ` [Qemu-devel] [PATCH 2/2] tpm: use loop iterator to set sts data field P J P
2018-11-06 8:13 ` Marc-André Lureau
2018-11-06 14:28 ` Stefan Berger
2018-11-06 14:26 ` Stefan Berger [this message]
2018-11-06 8:07 ` [Qemu-devel] [PATCH 1/2] tpm: check localities index Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef2e233-8413-8055-4282-4e6c46b2fa36@linux.ibm.com \
--to=stefanb@linux.ibm.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).