From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
Glenn Miles <milesg@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, clg@kaod.org,
andrew@codeconstruct.com.au, joel@jms.id.au
Subject: Re: [PATCH v2 RESEND] misc/led: LED state is set opposite of what is expected
Date: Fri, 27 Oct 2023 15:33:37 +0200 [thread overview]
Message-ID: <7f20a803-db3a-fd4a-bd43-04b21db1c14e@linaro.org> (raw)
In-Reply-To: <CAFEAcA8N7nUmoQHkhSFdVG+3amkW6N=jsVq8BqkfQAzygY_4yQ@mail.gmail.com>
On 27/10/23 13:51, Peter Maydell wrote:
> On Tue, 24 Oct 2023 at 20:20, Glenn Miles <milesg@linux.vnet.ibm.com> wrote:
>>
>> Testing of the LED state showed that when the LED polarity was
>> set to GPIO_POLARITY_ACTIVE_LOW and a low logic value was set on
>> the input GPIO of the LED, the LED was being turn off when it was
>> expected to be turned on.
>>
>> Signed-off-by: Glenn Miles <milesg@linux.vnet.ibm.com>
>> ---
>
>
>
> Applied to target-arm.next, thanks.
Sorry I'm still catching up.
Fixes: ddb67f6402 ("hw/misc/led: Allow connecting from GPIO output")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-10-27 13:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 19:19 [PATCH v2 RESEND] misc/led: LED state is set opposite of what is expected Glenn Miles
2023-10-25 12:59 ` Peter Maydell
2023-10-27 11:51 ` Peter Maydell
2023-10-27 13:33 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f20a803-db3a-fd4a-bd43-04b21db1c14e@linaro.org \
--to=philmd@linaro.org \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=joel@jms.id.au \
--cc=milesg@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).