From: "Cédric Le Goater" <clg@kaod.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Joel Stanley" <joel@jms.id.au>
Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>,
Andrew Jeffery <andrew@aj.id.au>,
Alistair Francis <alistair@alistair23.me>
Subject: Re: [PATCH v2 04/12] hw/ssi: Add an "addr" property to SSIPeripheral
Date: Wed, 7 Jun 2023 16:15:55 +0200 [thread overview]
Message-ID: <7f37de5f-d31d-b51c-340d-a04ae99230f0@kaod.org> (raw)
In-Reply-To: <62e69c35-4869-8cc3-5983-9f83ff649da9@linaro.org>
On 6/7/23 10:28, Philippe Mathieu-Daudé wrote:
> On 7/6/23 10:06, Joel Stanley wrote:
>> On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater <clg@kaod.org> wrote:
>>>
>>> Boards will use this new property to identify the device CS line and
>>> wire the SPI controllers accordingly.
>>
>> "addr" and not "cs" or even "chip-select"?
>
> "chip-select" is a good suggestion!
I thought of using "cs" initially as it makes more sense for SPI
controllers, I do agree. But then, I tried to be consistent with
what QEMU is proposing today : "bus" and "addr".
This can be changed.
Thanks,
C.
>
>> Reviewed-by: Joel Stanley <joel@jms.id.au>
>>
>>>
>>> Cc: Alistair Francis <alistair@alistair23.me>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>>> ---
>>> include/hw/ssi/ssi.h | 3 +++
>>> hw/ssi/ssi.c | 7 +++++++
>>> 2 files changed, 10 insertions(+)
>
next prev parent reply other threads:[~2023-06-07 14:16 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 4:39 [PATCH v2 00/12] aspeed: fixes and extensions Cédric Le Goater
2023-06-07 4:39 ` [PATCH v2 01/12] aspeed/hace: Initialize g_autofree pointer Cédric Le Goater
2023-06-07 7:53 ` Joel Stanley
2023-06-07 4:39 ` [PATCH v2 02/12] aspeed: Introduce a boot_rom region at the machine level Cédric Le Goater
2023-06-07 8:04 ` Joel Stanley
2023-06-07 4:39 ` [PATCH v2 03/12] aspeed: Use the boot_rom region of the fby35 machine Cédric Le Goater
2023-06-07 8:05 ` Joel Stanley
2023-06-29 10:57 ` Philippe Mathieu-Daudé
2023-06-07 4:39 ` [PATCH v2 04/12] hw/ssi: Add an "addr" property to SSIPeripheral Cédric Le Goater
2023-06-07 8:06 ` Joel Stanley
2023-06-07 8:28 ` Philippe Mathieu-Daudé
2023-06-07 14:15 ` Cédric Le Goater [this message]
2023-06-29 10:56 ` Philippe Mathieu-Daudé
2023-06-29 16:08 ` Cédric Le Goater
2023-06-07 4:39 ` [PATCH v2 05/12] hw/ssi: Introduce a ssi_get_cs() helper Cédric Le Goater
2023-06-07 8:10 ` Joel Stanley
2023-06-29 11:09 ` Philippe Mathieu-Daudé
2023-06-29 16:07 ` Cédric Le Goater
2023-06-07 4:39 ` [PATCH v2 06/12] aspeed/smc: Wire CS lines at reset Cédric Le Goater
2023-06-07 10:49 ` Joel Stanley
2023-06-07 17:05 ` Cédric Le Goater
2023-06-29 14:46 ` Cédric Le Goater
2023-06-07 4:39 ` [PATCH v2 07/12] hw/ssi: Check for duplicate addresses Cédric Le Goater
2023-06-07 10:52 ` Joel Stanley
2023-06-07 4:39 ` [PATCH v2 08/12] aspeed: Create flash devices only when defaults are enabled Cédric Le Goater
2023-06-07 4:39 ` [PATCH v2 09/12] m25p80: Introduce an helper to retrieve the BlockBackend of a device Cédric Le Goater
2023-06-07 10:55 ` Joel Stanley
2023-06-07 4:39 ` [PATCH v2 10/12] aspeed: Get the BlockBackend of FMC0 from the flash device Cédric Le Goater
2023-06-07 10:55 ` Joel Stanley
2023-06-07 4:39 ` [PATCH v2 11/12] aspeed: Introduce a "bmc-console" machine option Cédric Le Goater
2023-06-07 10:58 ` Joel Stanley
2023-06-07 4:39 ` [PATCH v2 12/12] target/arm: Allow users to set the number of VFP registers Cédric Le Goater
2023-06-07 11:06 ` Joel Stanley
2023-06-07 14:19 ` Cédric Le Goater
2023-06-08 10:19 ` Peter Maydell
2023-06-19 12:47 ` Mads Ynddal
2023-06-19 13:09 ` Cédric Le Goater
2023-06-19 13:46 ` Mads Ynddal
2023-06-19 13:41 ` Peter Maydell
2023-06-19 13:54 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f37de5f-d31d-b51c-340d-a04ae99230f0@kaod.org \
--to=clg@kaod.org \
--cc=alistair@alistair23.me \
--cc=andrew@aj.id.au \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).