From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2293C7EE25 for ; Wed, 7 Jun 2023 14:16:44 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q6txM-0001iC-4F; Wed, 07 Jun 2023 10:16:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6txG-0001fv-CZ; Wed, 07 Jun 2023 10:16:07 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q6txE-0002yj-O1; Wed, 07 Jun 2023 10:16:06 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4QbqBm4Mjbz4x4R; Thu, 8 Jun 2023 00:16:00 +1000 (AEST) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4QbqBj6JJMz4x4K; Thu, 8 Jun 2023 00:15:57 +1000 (AEST) Message-ID: <7f37de5f-d31d-b51c-340d-a04ae99230f0@kaod.org> Date: Wed, 7 Jun 2023 16:15:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v2 04/12] hw/ssi: Add an "addr" property to SSIPeripheral Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Joel Stanley Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, Peter Maydell , Andrew Jeffery , Alistair Francis References: <20230607043943.1837186-1-clg@kaod.org> <20230607043943.1837186-5-clg@kaod.org> <62e69c35-4869-8cc3-5983-9f83ff649da9@linaro.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= In-Reply-To: <62e69c35-4869-8cc3-5983-9f83ff649da9@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=150.107.74.76; envelope-from=SRS0=5JAy=B3=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.091, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 6/7/23 10:28, Philippe Mathieu-Daudé wrote: > On 7/6/23 10:06, Joel Stanley wrote: >> On Wed, 7 Jun 2023 at 04:40, Cédric Le Goater wrote: >>> >>> Boards will use this new property to identify the device CS line and >>> wire the SPI controllers accordingly. >> >> "addr" and not "cs" or even "chip-select"? > > "chip-select" is a good suggestion! I thought of using "cs" initially as it makes more sense for SPI controllers, I do agree. But then, I tried to be consistent with what QEMU is proposing today : "bus" and "addr". This can be changed. Thanks, C. > >> Reviewed-by: Joel Stanley >> >>> >>> Cc: Alistair Francis >>> Reviewed-by: Philippe Mathieu-Daudé >>> Signed-off-by: Cédric Le Goater >>> --- >>>   include/hw/ssi/ssi.h | 3 +++ >>>   hw/ssi/ssi.c         | 7 +++++++ >>>   2 files changed, 10 insertions(+) >