From: Richard Henderson <richard.henderson@linaro.org>
To: Jeff Kubascik <jeff.kubascik@dornerworks.com>,
Peter Maydell <peter.maydell@linaro.org>,
qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: Stewart Hildebrand <Stewart.Hildebrand@dornerworks.com>,
Jarvis Roach <Jarvis.Roach@dornerworks.com>
Subject: Re: [PATCH] target/arm: adjust program counter for wfi exception in AArch32
Date: Mon, 13 Jan 2020 16:41:34 -1000 [thread overview]
Message-ID: <7f45c4a2-0192-aaaa-8d0f-7ea7890ca448@linaro.org> (raw)
In-Reply-To: <20200110180211.29025-1-jeff.kubascik@dornerworks.com>
On 1/10/20 8:02 AM, Jeff Kubascik wrote:
> - env->pc -= insn_len;
> + if (env->aarch64)
> + env->pc -= insn_len;
> + else
> + env->regs[15] -= insn_len;
QEMU requires all braces. See CODING_STYLE.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-01-14 2:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 18:02 [PATCH] target/arm: adjust program counter for wfi exception in AArch32 Jeff Kubascik
2020-01-10 19:19 ` no-reply
2020-01-14 2:41 ` Richard Henderson [this message]
2020-01-14 13:22 ` Jeff Kubascik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f45c4a2-0192-aaaa-8d0f-7ea7890ca448@linaro.org \
--to=richard.henderson@linaro.org \
--cc=Jarvis.Roach@dornerworks.com \
--cc=Stewart.Hildebrand@dornerworks.com \
--cc=jeff.kubascik@dornerworks.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).