From: Paolo Bonzini <pbonzini@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
"Cleber Rosa" <crosa@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Daniel Berrange" <berrange@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>
Subject: Re: [PATCH 3/9] tests: use python3 as the python executable name
Date: Thu, 26 May 2022 14:16:28 +0200 [thread overview]
Message-ID: <7f6866aa-32f7-e2f8-dfaa-04f051a24a01@redhat.com> (raw)
In-Reply-To: <20220526000921.1581503-4-jsnow@redhat.com>
On 5/26/22 02:09, John Snow wrote:
> Use "python3" instead of "python" as per PEP0394:
> https://peps.python.org/pep-0394/
>
> This should always be defined (in a venv, at least!), matching the
> preferred python shebang of "#!/usr/bin/env python3".
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/Makefile.include | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 146aaa96a00..f68adda0650 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -89,7 +89,7 @@ TARGETS=$(patsubst libqemu-%.fa, %, $(filter libqemu-%.fa, $(ninja-targets)))
> TESTS_VENV_DIR=$(BUILD_DIR)/tests/venv
> TESTS_VENV_REQ=$(SRC_PATH)/tests/requirements.txt
> TESTS_RESULTS_DIR=$(BUILD_DIR)/tests/results
> -TESTS_PYTHON=$(TESTS_VENV_DIR)/bin/python
> +TESTS_PYTHON=$(TESTS_VENV_DIR)/bin/python3
> ifndef AVOCADO_TESTS
> AVOCADO_TESTS=tests/avocado
> endif
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
next prev parent reply other threads:[~2022-05-26 12:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-26 0:09 [PATCH 0/9] tests, python: prepare to expand usage of test venv John Snow
2022-05-26 0:09 ` [PATCH 1/9] python: update for mypy 0.950 John Snow
2022-05-26 0:09 ` [PATCH 2/9] tests: add "TESTS_PYTHON" variable to Makefile John Snow
2022-05-26 0:09 ` [PATCH 3/9] tests: use python3 as the python executable name John Snow
2022-05-26 12:16 ` Paolo Bonzini [this message]
2022-05-26 0:09 ` [PATCH 4/9] tests: silence pip upgrade warnings during venv creation John Snow
2022-05-26 12:16 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 5/9] tests: add quiet-venv-pip macro John Snow
2022-05-26 12:15 ` Paolo Bonzini
2022-05-26 14:17 ` John Snow
2022-05-26 19:54 ` Paolo Bonzini
2022-05-26 12:16 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 6/9] tests: install "qemu" namespace package into venv John Snow
2022-05-26 12:15 ` Paolo Bonzini
2022-05-26 0:09 ` [PATCH 7/9] tests: use tests/venv to run basevm.py-based scripts John Snow
2022-05-26 0:09 ` [PATCH 8/9] tests: add python3-venv to debian10.docker John Snow
2022-05-26 12:14 ` Paolo Bonzini
2022-05-30 7:33 ` Thomas Huth
2022-05-31 18:28 ` John Snow
2022-06-01 7:29 ` Thomas Huth
2022-06-02 17:44 ` John Snow
2022-05-26 0:09 ` [PATCH 9/9] tests: run 'device-crash-test' from tests/venv John Snow
2022-05-26 12:14 ` Paolo Bonzini
2022-05-26 14:14 ` John Snow
2022-05-26 14:34 ` [PATCH 0/9] tests, python: prepare to expand usage of test venv John Snow
2022-06-01 10:06 ` Paolo Bonzini
2022-05-27 14:27 ` John Snow
2022-06-01 10:06 ` Paolo Bonzini
2022-06-02 17:43 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f6866aa-32f7-e2f8-dfaa-04f051a24a01@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=crosa@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).