From: Jason Wang <jasowang@redhat.com>
To: Cornelia Huck <cohuck@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Cc: Yuri Benditovich <yuri.benditovich@daynix.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling
Date: Tue, 28 Apr 2020 16:19:15 +0800 [thread overview]
Message-ID: <7f703bea-2cae-dcdc-71bd-9623c7db33ac@redhat.com> (raw)
In-Reply-To: <20200427102415.10915-4-cohuck@redhat.com>
On 2020/4/27 下午6:24, Cornelia Huck wrote:
> VIRTIO_NET_HDR_F_RSC_INFO is available in the headers now.
>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/net/virtio-net.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index e85d902588b3..7449570c7123 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -77,14 +77,6 @@
> tso/gso/gro 'off'. */
> #define VIRTIO_NET_RSC_DEFAULT_INTERVAL 300000
>
> -/* temporary until standard header include it */
> -#if !defined(VIRTIO_NET_HDR_F_RSC_INFO)
> -
> -#define VIRTIO_NET_HDR_F_RSC_INFO 4 /* rsc_ext data in csum_ fields */
> -#define VIRTIO_NET_F_RSC_EXT 61
> -
> -#endif
> -
> static inline __virtio16 *virtio_net_rsc_ext_num_packets(
> struct virtio_net_hdr *hdr)
> {
I think we should not keep the those tricky num_packets/dup_acks.
Thanks
next prev parent reply other threads:[~2020-04-28 8:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 10:24 [PATCH 0/3] headers update and virtio-net fixup Cornelia Huck
2020-04-27 10:24 ` [PATCH 1/3] virtio-net: fix rsc_ext compat handling Cornelia Huck
2020-04-27 10:24 ` [PATCH 2/3] linux-headers: update against Linux 5.7-rc3 Cornelia Huck
2020-04-27 11:31 ` Michael S. Tsirkin
2020-04-27 10:24 ` [PATCH 3/3] virtio-net: remove VIRTIO_NET_HDR_F_RSC_INFO compat handling Cornelia Huck
2020-04-27 11:32 ` Michael S. Tsirkin
2020-04-28 8:19 ` Jason Wang [this message]
2020-04-28 8:34 ` Cornelia Huck
2020-04-28 8:58 ` Jason Wang
2020-04-28 9:18 ` Cornelia Huck
2020-04-28 10:55 ` Yuri Benditovich
2020-04-28 13:04 ` Jason Wang
2020-04-28 13:00 ` Jason Wang
2020-04-27 11:29 ` [PATCH 0/3] headers update and virtio-net fixup Michael S. Tsirkin
2020-04-28 11:35 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f703bea-2cae-dcdc-71bd-9623c7db33ac@redhat.com \
--to=jasowang@redhat.com \
--cc=cohuck@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).