From: Eric Blake <eblake@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-block@nongnu.org, Markus Armbruster <armbru@redhat.com>,
Coiby Xu <Coiby.Xu@gmail.com>, Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH v2 3/4] block: move block exports to libblockdev
Date: Tue, 29 Sep 2020 08:03:09 -0500 [thread overview]
Message-ID: <7f87a6b5-0ceb-f9ba-5ecd-29086ca3bda2@redhat.com> (raw)
In-Reply-To: <20200929125516.186715-4-stefanha@redhat.com>
On 9/29/20 7:55 AM, Stefan Hajnoczi wrote:
> Block exports are used by softmmu, qemu-storage-daemon, and qemu-nbd.
> They are not used by other programs and are not otherwise needed in
> libblock.
>
> Undo the recent move of blockdev-nbd.c from blockdev_ss into block_ss.
> Since bdrv_close_all() (libblock) calls blk_exp_close_all()
> (libblockdev) a stub function is required..
>
> Make qemu-ndb.c use signal handling utility functions instead of
nbd
> duplicating the code. This helps because os-posix.c is in libblockdev
> and it depends on a qemu_system_killed() symbol that qemu-nbd.c lacks.
> Once we use the signal handling utility functions we also end up
> providing the necessary symbol.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-09-29 13:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-29 12:55 [PATCH v2 0/4] block/export: add BlockExportOptions->iothread member Stefan Hajnoczi
2020-09-29 12:55 ` [PATCH v2 1/4] util/vhost-user-server: use static library in meson.build Stefan Hajnoczi
2020-09-29 12:55 ` [PATCH v2 2/4] qemu-storage-daemon: avoid compiling blockdev_ss twice Stefan Hajnoczi
2020-09-29 12:55 ` [PATCH v2 3/4] block: move block exports to libblockdev Stefan Hajnoczi
2020-09-29 13:02 ` Paolo Bonzini
2020-09-29 13:03 ` Eric Blake [this message]
2020-09-29 17:36 ` Eric Blake
2020-09-30 8:51 ` Stefan Hajnoczi
2020-09-29 12:55 ` [PATCH v2 4/4] block/export: add iothread and fixed-iothread options Stefan Hajnoczi
2020-09-29 13:07 ` Eric Blake
2020-09-29 15:44 ` Stefan Hajnoczi
2020-10-09 10:17 ` [PATCH v2 0/4] block/export: add BlockExportOptions->iothread member Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f87a6b5-0ceb-f9ba-5ecd-29086ca3bda2@redhat.com \
--to=eblake@redhat.com \
--cc=Coiby.Xu@gmail.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lvivier@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).