Re: [PATCH v6 2/9] migration: convert uri parameter into 'MigrateAddress' struct

[Het Gala <het.gala@nutanix.com>]

On 05/07/23 4:59 pm, Markus Armbruster wrote:
> Drive-by comment...
>
> Het Gala <het.gala@nutanix.com> writes:
>
>> This patch parses 'migrate' and 'migrate-incoming' QAPI's 'uri' parameter
>> with all the migration connection related information and stores them
>> inside well defined 'MigrateAddress' struct.
>>
>> Misc: limit line width in exec.c to 80 characters recommended by Qemu.
>>
>> Suggested-by: Aravind Retnakaran <aravind.retnakaran@nutanix.com>
>> Signed-off-by: Het Gala <het.gala@nutanix.com>
> [...]
>
>> diff --git a/migration/migration.c b/migration/migration.c
>> index dc05c6f6ea..0eb25bb5a4 100644
>> --- a/migration/migration.c
>> +++ b/migration/migration.c
>> @@ -64,6 +64,7 @@
>>   #include "yank_functions.h"
>>   #include "sysemu/qtest.h"
>>   #include "options.h"
>> +#include "qemu/sockets.h"
>>   
>>   static NotifierList migration_state_notifiers =
>>       NOTIFIER_LIST_INITIALIZER(migration_state_notifiers);
>> @@ -420,15 +421,63 @@ void migrate_add_address(SocketAddress *address)
>>                         QAPI_CLONE(SocketAddress, address));
>>   }
>>   
>> +static bool migrate_uri_parse(const char *uri,
>> +                              MigrationAddress **channel,
>> +                              Error **errp)
>> +{
>> +    g_autoptr(MigrationAddress) addrs = g_new0(MigrationAddress, 1);
> @addrs suggests plural, yet it points to a single MigrationAddress.
> Recommend @addr.
>
> Same elsewhere.
Ack.
> [...]
Regards,
Het Gala