From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1138CCD1BF for ; Wed, 29 Oct 2025 05:44:06 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vDyxK-0007hs-6X; Wed, 29 Oct 2025 01:42:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDyxH-0007hU-Is for qemu-devel@nongnu.org; Wed, 29 Oct 2025 01:42:43 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vDyxE-0003a5-NM for qemu-devel@nongnu.org; Wed, 29 Oct 2025 01:42:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1761716556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=UEtErXeJnzm1qtBA7pw7yDQa55ynkrYSe2wJiLVtsAU=; b=X+nUHqv2uSzPjpKy0Pp1W8lJE5ubKO8rtaC9qf0WQNuGrFKCKfLfBddGs9Tuf1FLlkHHm9 ZZ7GusDvKKIxYHRiqiIUNEm+++qw+I/7OLaQaVOl3fEZ7hoRUTI5N3W9hLeL8Bo9uoysis /z7+Nkt5RvlKM+FtMUN4746KGNmNULc= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-13-KFp2V1EJPFS4-jbruxsOQA-1; Wed, 29 Oct 2025 01:42:34 -0400 X-MC-Unique: KFp2V1EJPFS4-jbruxsOQA-1 X-Mimecast-MFC-AGG-ID: KFp2V1EJPFS4-jbruxsOQA_1761716553 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-42851b6a659so5454223f8f.1 for ; Tue, 28 Oct 2025 22:42:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761716553; x=1762321353; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=UEtErXeJnzm1qtBA7pw7yDQa55ynkrYSe2wJiLVtsAU=; b=vdURcNpijlzNq/SnWEfFja0h5uDxCnfsut5Vlr4MmDf4sXcDrxTWqpmCScJS5XPQ9g YZXyI+UbE/vY2cQxqCb3f1Ey1rjKjRkwKbGaiRZKQkOM+pJDB5hcOp7bF0lSjv2e3H50 xOkPmL/gQN8tTY44UA3PZ1Xps0/iwJcvdAOuEwOGYd6jE2X/aXDciyJNH1SfT1zoOrnL 2EuN3smbr+8ikR0tLcL7nNwDNZZazdhZXEHkbmcUCEG5bAsgyfujDKp3HWihl7ldFrAq 6ssoQkArd9Q/XTeEm0F09OyUlQK1p+FJoaETF1Dy6sk1XkBXNmoV9nZN3i6RkfWgFAsG UuRg== X-Forwarded-Encrypted: i=1; AJvYcCUxMgLXJA6p9t915iCoECC3JALarso4kXiNaqnwZjROPVJoxEYNgNub+O0oG9+3Cm3yjwyM/7UXYUMT@nongnu.org X-Gm-Message-State: AOJu0Yz1V2JLaNiH5GRb08QyFWbKZ0g63Xl0bHIfu3wYA83tUgn8Y7G9 FbiVqoQ6Xf/5Mg79r1n+8Utg+yZxQOM4AHfqEThoMuKjIUpdxfYx++o9MvuyGsP6AFZaqcqhu5f fzBqlySNftq2WFegAEm9j/j9AyBpwkwAgrNKhv3Zi120lByaKwGKk1Mfq X-Gm-Gg: ASbGncv4c4seJh8/J/4UNegqFlNU3n6xd/ws9/8K8Lz0iv0rHoZJnDEnru/Fiss8dix FzVEjr1Vn7uXPRVul2jLlC6XrT7r3SP9UBGVQrt8hAez949rtdGAOBJwzmfrbNRpcinb3XpBQL9 nA62DlvRe9Z3gXFgNBTkVThyKLkVXzocxytb31ni0TaRizBmlY9ky/liUsURk9I+0C2UfKA93OC lt9asaGMXJLU8aQqdDdl74HcFQyWZVDnKUYWDTlENeC8ce5SBVBrkI8gDCWmBvQHbk4sZ2Zqdmv 6FEVqLbySNPYjuzWntfG0kjPMLML/SFE4+3xkDHcUMvuepjehukDdWlEM7wrXOwPjoDSyLk= X-Received: by 2002:a05:6000:2c04:b0:3e9:a1cb:ea8f with SMTP id ffacd0b85a97d-429aefcda8bmr1128930f8f.52.1761716552828; Tue, 28 Oct 2025 22:42:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJNzrcg4RUdm3nZ2Fh2q9TNcYknGGflcngT80/4Yr/Gs+VbKl9owFD7hyZhBNzNuAGUOvbiA== X-Received: by 2002:a05:6000:2c04:b0:3e9:a1cb:ea8f with SMTP id ffacd0b85a97d-429aefcda8bmr1128900f8f.52.1761716552370; Tue, 28 Oct 2025 22:42:32 -0700 (PDT) Received: from [192.168.0.7] ([47.64.112.33]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429952b7b6fsm24387163f8f.1.2025.10.28.22.42.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Oct 2025 22:42:31 -0700 (PDT) Message-ID: <7f9a015e-6aa3-4bcf-bdad-8d09d5924878@redhat.com> Date: Wed, 29 Oct 2025 06:42:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 09/25] hw/s390x: Use memory_region_size() To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Mark Cave-Ayland , qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-block@nongnu.org, =?UTF-8?Q?Marc-Andr=C3=A9_Lureau?= , qemu-arm@nongnu.org, qemu-s390x@nongnu.org, Matthew Rosato , Eric Farman , Halil Pasic , Christian Borntraeger , Richard Henderson , David Hildenbrand , Ilya Leoshkevich References: <20251028181300.41475-1-philmd@linaro.org> <20251028181300.41475-10-philmd@linaro.org> Content-Language: en-US From: Thomas Huth Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzR5UaG9tYXMgSHV0 aCA8dGh1dGhAcmVkaGF0LmNvbT7CwXgEEwECACIFAlVgX6oCGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAAoJEC7Z13T+cC21EbIP/ii9cvT2HHGbFRl8HqGT6+7Wkb+XLMqJBMAIGiQK QIP3xk1HPTsLfVG0ao4hy/oYkGNOP8+ubLnZen6Yq3zAFiMhQ44lvgigDYJo3Ve59gfe99KX EbtB+X95ODARkq0McR6OAsPNJ7gpEUzfkQUUJTXRDQXfG/FX303Gvk+YU0spm2tsIKPl6AmV 1CegDljzjycyfJbk418MQmMu2T82kjrkEofUO2a24ed3VGC0/Uz//XCR2ZTo+vBoBUQl41BD eFFtoCSrzo3yPFS+w5fkH9NT8ChdpSlbNS32NhYQhJtr9zjWyFRf0Zk+T/1P7ECn6gTEkp5k ofFIA4MFBc/fXbaDRtBmPB0N9pqTFApIUI4vuFPPO0JDrII9dLwZ6lO9EKiwuVlvr1wwzsgq zJTPBU3qHaUO4d/8G+gD7AL/6T4zi8Jo/GmjBsnYaTzbm94lf0CjXjsOX3seMhaE6WAZOQQG tZHAO1kAPWpaxne+wtgMKthyPLNwelLf+xzGvrIKvLX6QuLoWMnWldu22z2ICVnLQChlR9d6 WW8QFEpo/FK7omuS8KvvopFcOOdlbFMM8Y/8vBgVMSsK6fsYUhruny/PahprPbYGiNIhKqz7 UvgyZVl4pBFjTaz/SbimTk210vIlkDyy1WuS8Zsn0htv4+jQPgo9rqFE4mipJjy/iboDzsFN BFH7eUwBEAC2nzfUeeI8dv0C4qrfCPze6NkryUflEut9WwHhfXCLjtvCjnoGqFelH/PE9NF4 4VPSCdvD1SSmFVzu6T9qWdcwMSaC+e7G/z0/AhBfqTeosAF5XvKQlAb9ZPkdDr7YN0a1XDfa +NgA+JZB4ROyBZFFAwNHT+HCnyzy0v9Sh3BgJJwfpXHH2l3LfncvV8rgFv0bvdr70U+On2XH 5bApOyW1WpIG5KPJlDdzcQTyptOJ1dnEHfwnABEfzI3dNf63rlxsGouX/NFRRRNqkdClQR3K gCwciaXfZ7ir7fF0u1N2UuLsWA8Ei1JrNypk+MRxhbvdQC4tyZCZ8mVDk+QOK6pyK2f4rMf/ WmqxNTtAVmNuZIwnJdjRMMSs4W4w6N/bRvpqtykSqx7VXcgqtv6eqoDZrNuhGbekQA0sAnCJ VPArerAZGArm63o39me/bRUQeQVSxEBmg66yshF9HkcUPGVeC4B0TPwz+HFcVhheo6hoJjLq knFOPLRj+0h+ZL+D0GenyqD3CyuyeTT5dGcNU9qT74bdSr20k/CklvI7S9yoQje8BeQAHtdV cvO8XCLrpGuw9SgOS7OP5oI26a0548M4KldAY+kqX6XVphEw3/6U1KTf7WxW5zYLTtadjISB X9xsRWSU+Yqs3C7oN5TIPSoj9tXMoxZkCIHWvnqGwZ7JhwARAQABwsFfBBgBAgAJBQJR+3lM AhsMAAoJEC7Z13T+cC21hPAQAIsBL9MdGpdEpvXs9CYrBkd6tS9mbaSWj6XBDfA1AEdQkBOn ZH1Qt7HJesk+qNSnLv6+jP4VwqK5AFMrKJ6IjE7jqgzGxtcZnvSjeDGPF1h2CKZQPpTw890k fy18AvgFHkVk2Oylyexw3aOBsXg6ukN44vIFqPoc+YSU0+0QIdYJp/XFsgWxnFIMYwDpxSHS 5fdDxUjsk3UBHZx+IhFjs2siVZi5wnHIqM7eK9abr2cK2weInTBwXwqVWjsXZ4tq5+jQrwDK cvxIcwXdUTLGxc4/Z/VRH1PZSvfQxdxMGmNTGaXVNfdFZjm4fz0mz+OUi6AHC4CZpwnsliGV ODqwX8Y1zic9viSTbKS01ZNp175POyWViUk9qisPZB7ypfSIVSEULrL347qY/hm9ahhqmn17 Ng255syASv3ehvX7iwWDfzXbA0/TVaqwa1YIkec+/8miicV0zMP9siRcYQkyTqSzaTFBBmqD oiT+z+/E59qj/EKfyce3sbC9XLjXv3mHMrq1tKX4G7IJGnS989E/fg6crv6NHae9Ckm7+lSs IQu4bBP2GxiRQ+NV3iV/KU3ebMRzqIC//DCOxzQNFNJAKldPe/bKZMCxEqtVoRkuJtNdp/5a yXFZ6TfE1hGKrDBYAm4vrnZ4CXFSBDllL59cFFOJCkn4Xboj/aVxxJxF30bn In-Reply-To: <20251028181300.41475-10-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 28/10/2025 19.12, Philippe Mathieu-Daudé wrote: > MemoryRegion::size is private data of MemoryRegion, > use the proper memory_region_size() getter to get it. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/s390x/s390-pci-inst.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c > index a3bb5aa2216..5841dfc4fec 100644 > --- a/hw/s390x/s390-pci-inst.c > +++ b/hw/s390x/s390-pci-inst.c > @@ -396,7 +396,7 @@ static MemoryRegion *s390_get_subregion(MemoryRegion *mr, uint64_t offset, > uint64_t subregion_size; > > QTAILQ_FOREACH(subregion, &mr->subregions, subregions_link) { > - subregion_size = int128_get64(subregion->size); > + subregion_size = memory_region_size(subregion); > if ((offset >= subregion->addr) && > (offset + len) <= (subregion->addr + subregion_size)) { > mr = subregion; Reviewed-by: Thomas Huth