qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: "Willian Rampazzo" <willianr@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH] gitlab-ci: Split custom-runners.yml in one file per runner
Date: Mon, 15 Nov 2021 15:33:33 +0100	[thread overview]
Message-ID: <7fb209d4-0d3c-af8f-f08d-d051d3b73e09@redhat.com> (raw)
In-Reply-To: <20211115095608.2436223-1-philmd@redhat.com>

On 15/11/2021 10.56, Philippe Mathieu-Daudé wrote:
> To ease maintenance, add the custom-runners/ directory and
> split custom-runners.yml in 3 files, all included by the
> current custom-runners.yml:
>   - ubuntu-18.04-s390x.yml
>   - ubuntu-20.04-aarch64.yml
>   - centos-stream-8-x86_64.yml
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> Based-on: <20211111160501.862396-1-crosa@redhat.com>
> https://gitlab.com/stsquad/qemu/-/tree/for-6.2/misc-fixes
> ---
>   .gitlab-ci.d/custom-runners.yml               | 268 +-----------------
>   .../custom-runners/centos-stream-8-x86_64.yml |  28 ++
>   .../custom-runners/ubuntu-18.04-s390x.yml     | 118 ++++++++
>   .../custom-runners/ubuntu-20.04-aarch64.yml   | 118 ++++++++
>   4 files changed, 268 insertions(+), 264 deletions(-)
>   create mode 100644 .gitlab-ci.d/custom-runners/centos-stream-8-x86_64.yml
>   create mode 100644 .gitlab-ci.d/custom-runners/ubuntu-18.04-s390x.yml
>   create mode 100644 .gitlab-ci.d/custom-runners/ubuntu-20.04-aarch64.yml

Should there maybe be entries in MAINTAINERS for these new files, so that it 
is clear who takes care of the external runners?

  Thomas



  parent reply	other threads:[~2021-11-15 14:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15  9:56 [PATCH] gitlab-ci: Split custom-runners.yml in one file per runner Philippe Mathieu-Daudé
2021-11-15 14:22 ` Alex Bennée
2021-11-15 14:32   ` Philippe Mathieu-Daudé
2021-11-15 14:33 ` Thomas Huth [this message]
2021-11-15 15:01   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fb209d4-0d3c-af8f-f08d-d051d3b73e09@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wainersm@redhat.com \
    --cc=willianr@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).