Re: [PATCH v7 03/16] backends/igvm: Add IGVM loader and configuration

[David Hildenbrand <david@redhat.com>]

On 27.02.25 14:44, Roy Hopkins wrote:
> Adds an IGVM loader to QEMU which processes a given IGVM file and
> applies the directives within the file to the current guest
> configuration.
> 
> The IGVM loader can be used to configure both confidential and
> non-confidential guests. For confidential guests, the
> ConfidentialGuestSupport object for the system is used to encrypt
> memory, apply the initial CPU state and perform other confidential guest
> operations.
> 
> The loader is configured via a new IgvmCfg QOM object which allows the
> user to provide a path to the IGVM file to process.
> 
> Signed-off-by: Roy Hopkins <roy.hopkins@randomman.co.uk>
> Acked-by: Michael S. Tsirkin <mst@redhat.com>
> Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
> ---
>   backends/igvm-cfg.c       |  52 +++
>   backends/igvm.c           | 808 ++++++++++++++++++++++++++++++++++++++
>   backends/igvm.h           |  23 ++

Just a general comment that could also be considered at a later point, 
after this was moved: Is "backends" really the right directory, and if 
so, would it make sense to start adding sub-directories? For example, 
all "hostmem" stuff could be moved into a subdirectory.

Would an "igvm" directory also be the right place for 
backends/confidential-guest-support.c, or would we be looking for 
something more abstract?

-- 
Cheers,

David / dhildenb