From: Eric Blake <eblake@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org
Cc: paolo.bonzini@gmail.com, berrange@redhat.com,
qemu-stable@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/3] qapi: fix crash when a parameter is missing
Date: Thu, 22 Sep 2016 08:59:38 -0500 [thread overview]
Message-ID: <7fe25d07-f224-73f1-4752-55911d755fa7@redhat.com> (raw)
In-Reply-To: <20160922130905.4720-3-marcandre.lureau@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 773 bytes --]
On 09/22/2016 08:09 AM, Marc-André Lureau wrote:
> Calling:
>
> { "execute": "qom-set",
> "arguments": { "path": "/machine", "property": "rtc-time" } }
>
> Will crash with:
>
> qapi/qapi-visit-core.c:277: visit_type_any: Assertion `!err != !*obj'
> failed
>
> Clear the obj and return an error.
>
> The patch also fixes a similar potential crash in qmp_input_type_null()
> by checking qmp_input_get_object() returned a valid qobj.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> qapi/qmp-input-visitor.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-09-22 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 13:09 [Qemu-devel] [PATCH v2 0/3] Fix some qapi assert() Marc-André Lureau
2016-09-22 13:09 ` [Qemu-devel] [PATCH v2 1/3] qmp: fix object-add assert() without props Marc-André Lureau
2016-09-22 13:57 ` Eric Blake
2016-09-22 13:09 ` [Qemu-devel] [PATCH v2 2/3] qapi: fix crash when a parameter is missing Marc-André Lureau
2016-09-22 13:59 ` Eric Blake [this message]
2016-09-22 13:09 ` [Qemu-devel] [PATCH v2 3/3] tests: start generic qemu-qmp tests Marc-André Lureau
2016-09-22 13:34 ` Daniel P. Berrange
2016-09-22 14:49 ` [Qemu-devel] [PATCH v2 0/3] Fix some qapi assert() no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fe25d07-f224-73f1-4752-55911d755fa7@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=paolo.bonzini@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).