From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Cédric Le Goater" <clg@kaod.org>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, "Anton Johansson" <anjo@rev.ng>,
"QEMU Trivial" <qemu-trivial@nongnu.org>
Subject: Re: [PATCH] hw/intc/xics: Include missing 'cpu.h' header
Date: Tue, 30 Jan 2024 07:42:10 +0100 [thread overview]
Message-ID: <7fe7bec4-95e8-40ca-8e8f-d4f9cd49385e@redhat.com> (raw)
In-Reply-To: <20240129170529.74305-1-philmd@linaro.org>
On 29/01/2024 18.05, Philippe Mathieu-Daudé wrote:
> Include missing headers in order to avoid when refactoring
> unrelated headers:
>
> hw/intc/xics.c: In function 'icp_realize':
> hw/intc/xics.c:304:5: error: unknown type name 'PowerPCCPU'
> 304 | PowerPCCPU *cpu;
> | ^~~~~~~~~~
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> hw/intc/xics.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/intc/xics.c b/hw/intc/xics.c
> index 8b25787227..700abfa7a6 100644
> --- a/hw/intc/xics.c
> +++ b/hw/intc/xics.c
> @@ -40,6 +40,7 @@
> #include "hw/irq.h"
> #include "sysemu/kvm.h"
> #include "sysemu/reset.h"
> +#include "target/ppc/cpu.h"
>
> void icp_pic_print_info(ICPState *icp, Monitor *mon)
> {
Reviewed-by: Thomas Huth <thuth@redhat.com>
prev parent reply other threads:[~2024-01-30 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 17:05 [PATCH] hw/intc/xics: Include missing 'cpu.h' header Philippe Mathieu-Daudé
2024-01-30 6:42 ` Thomas Huth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fe7bec4-95e8-40ca-8e8f-d4f9cd49385e@redhat.com \
--to=thuth@redhat.com \
--cc=anjo@rev.ng \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).