From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94373C433E1 for ; Mon, 20 Jul 2020 15:03:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5EA6022B4E for ; Mon, 20 Jul 2020 15:03:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="FUiM/F1Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5EA6022B4E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43262 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jxXJk-0003zw-KM for qemu-devel@archiver.kernel.org; Mon, 20 Jul 2020 11:03:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42312) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jxXIt-0003P6-Mb for qemu-devel@nongnu.org; Mon, 20 Jul 2020 11:02:07 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:44712 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1jxXIq-000195-Ki for qemu-devel@nongnu.org; Mon, 20 Jul 2020 11:02:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595257322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=tm1NOCkLQdOV5C1dTSoJG4nwgpbfT/B9Hoj12HwK6Ao=; b=FUiM/F1Qj4PyK9NhvTvrARUDK5A+R+63a5U/6B/MDz9T4EUlus1wrIkXP/BHeWnmvBnHFG ci6wLvfoYVDl/fSFuXlXJaE8bGPu0BQio0hOPhwx5o6Qvl9b6lun33bMzM4ywcjxr92MFB Z+sVeIeIGp6j9Sesq0bEIEhZxjV0Qro= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-43-5HkIv0GkNauSKv5x_Sr1aA-1; Mon, 20 Jul 2020 11:01:47 -0400 X-MC-Unique: 5HkIv0GkNauSKv5x_Sr1aA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9AAC3102C7F1 for ; Mon, 20 Jul 2020 15:01:46 +0000 (UTC) Received: from turbo.dinechin.lan (ovpn-114-55.ams2.redhat.com [10.36.114.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6E52D7303C; Mon, 20 Jul 2020 15:01:39 +0000 (UTC) References: <20200624131045.14512-1-kraxel@redhat.com> <20200624131045.14512-8-kraxel@redhat.com> User-agent: mu4e 1.5.5; emacs 26.3 From: Christophe de Dinechin To: Gerd Hoffmann Subject: Re: [PATCH v5 07/10] vga: build qxl as module In-reply-to: <20200624131045.14512-8-kraxel@redhat.com> Date: Mon, 20 Jul 2020 17:01:37 +0200 Message-ID: <7hpn8qqlgu.fsf@turbo.dinechin.lan> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dinechin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain Received-SPF: pass client-ip=207.211.31.81; envelope-from=dinechin@redhat.com; helo=us-smtp-delivery-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/19 21:45:06 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?utf-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Eduardo Habkost , qemu-devel@nongnu.org, =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Paolo Bonzini , philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2020-06-24 at 15:10 CEST, Gerd Hoffmann wrote... > First step in making spice support modular. > > Signed-off-by: Gerd Hoffmann > --- > util/module.c | 2 ++ > hw/Makefile.objs | 1 + > hw/display/Makefile.objs | 5 ++++- > 3 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/util/module.c b/util/module.c > index e3226165e91c..7c76d2a84b94 100644 > --- a/util/module.c > +++ b/util/module.c > @@ -264,6 +264,8 @@ static struct { > { "ccid-card-passthru", "hw-", "usb-smartcard" }, > { "ccid-card-emulated", "hw-", "usb-smartcard" }, > { "usb-redir", "hw-", "usb-redirect" }, > + { "qxl-vga", "hw-", "display-qxl" }, > + { "qxl", "hw-", "display-qxl" }, > }; > > static bool module_loaded_qom_all; > diff --git a/hw/Makefile.objs b/hw/Makefile.objs > index af8fd9a510ed..14b7ea4eb62e 100644 > --- a/hw/Makefile.objs > +++ b/hw/Makefile.objs > @@ -43,5 +43,6 @@ devices-dirs-y += smbios/ > endif > > common-obj-y += $(devices-dirs-y) > +common-obj-m += display/ > common-obj-m += usb/ > obj-y += $(devices-dirs-y) > diff --git a/hw/display/Makefile.objs b/hw/display/Makefile.objs > index 77a7d622bd2d..76b3571e4902 100644 > --- a/hw/display/Makefile.objs > +++ b/hw/display/Makefile.objs > @@ -44,7 +44,10 @@ common-obj-$(CONFIG_ARTIST) += artist.o > > obj-$(CONFIG_VGA) += vga.o > > -common-obj-$(CONFIG_QXL) += qxl.o qxl-logger.o qxl-render.o > +ifeq ($(CONFIG_QXL),y) > +common-obj-m += qxl.mo > +qxl.mo-objs = qxl.o qxl-logger.o qxl-render.o > +endif > > obj-$(CONFIG_VIRTIO_GPU) += virtio-gpu-base.o virtio-gpu.o virtio-gpu-3d.o > obj-$(CONFIG_VHOST_USER_GPU) += vhost-user-gpu.o Reviewed-by: Christophe de Dinechin -- Cheers, Christophe de Dinechin (IRC c3d)