From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41885)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1buzv4-00064c-As
	for qemu-devel@nongnu.org; Fri, 14 Oct 2016 06:40:55 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1buzv2-0002tv-Dj
	for qemu-devel@nongnu.org; Fri, 14 Oct 2016 06:40:53 -0400
References: <1476380062-18001-1-git-send-email-pbonzini@redhat.com>
	<1476380062-18001-7-git-send-email-pbonzini@redhat.com>
	<20161014103346.GD14830@lemon>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <8001bdd1-ecf5-02d7-9ba3-1776c087f7d6@redhat.com>
Date: Fri, 14 Oct 2016 12:40:41 +0200
MIME-Version: 1.0
In-Reply-To: <20161014103346.GD14830@lemon>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 06/18] qed: Implement .bdrv_drain
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, kwolf@redhat.com, stefanha@redhat.com



On 14/10/2016 12:33, Fam Zheng wrote:
>> > +    bdrv_aio_flush(s->bs->file->bs, qed_clear_need_check, s);
> If this one has to change, what about the other bdrv_aio_flush(s->bs, ...) down
> in this call path:
> 
>     qed_need_check_timer_cb
>         qed_clear_need_check
>             qed_write_header
>                 qed_flush_after_clear_need_check

It was really just for clarity, so I guess I can change all four of them
in a separate patch.

Paolo