From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: Yuri Benditovich <yuri.benditovich@daynix.com>
Cc: Jason Wang <jasowang@redhat.com>,
Dmitry Fleytman <dmitry.fleytman@gmail.com>,
Sriram Yagnaraman <sriram.yagnaraman@est.tech>,
"Michael S. Tsirkin" <mst@redhat.com>,
Luigi Rizzo <rizzo@iet.unipi.it>,
Giuseppe Lettieri <g.lettieri@iet.unipi.it>,
Vincenzo Maffione <v.maffione@gmail.com>,
Andrew Melnychenko <andrew@daynix.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v9 16/20] virtio-net: Do not write hashes to peer buffer
Date: Mon, 8 Apr 2024 10:30:51 +0900 [thread overview]
Message-ID: <8010b335-4b46-456e-bf6e-c191cdc34964@daynix.com> (raw)
In-Reply-To: <CAOEp5Od=KUTHnikVBA7iWfdFPJ=T7hbJrSu4zwCiB_Q1P-Sz+Q@mail.gmail.com>
On 2024/04/08 7:09, Yuri Benditovich wrote:
> On Wed, Apr 3, 2024 at 2:12 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>>
>> The peer buffer is qualified with const and not meant to be modified.
>
> IMHO, this buffer is not so 'const' (although the prototype states so),
> it is allocated in net.c
> btw, another procedure in this file also modifies the buffer
> (work_around_broken_dhclient)
Right but it has a FIXME comment.
>
>> It also prevents enabling VIRTIO_NET_F_HASH_REPORT for peers without
>> virtio-net header support.
>
> Does it mean _this commit_ prevents enabling VIRTIO_NET_F_HASH_REPORT
> for peers without
> virtio-net header support? Where?
No, but I meant that this patch fixes such a problem.
Regards,
Akihiko Odaki
next prev parent reply other threads:[~2024-04-08 1:31 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 11:10 [PATCH v9 00/20] virtio-net RSS/hash report fixes and improvements Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 01/20] tap: Remove tap_probe_vnet_hdr_len() Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 02/20] tap: Remove qemu_using_vnet_hdr() Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 03/20] net: Move virtio-net header length assertion Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 04/20] net: Remove receive_raw() Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 05/20] tap: Call tap_receive_iov() from tap_receive() Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 06/20] tap: Shrink zeroed virtio-net header Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 07/20] virtio-net: Do not propagate ebpf-rss-fds errors Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 08/20] virtio-net: Add only one queue pair when realizing Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 09/20] virtio-net: Copy header only when necessary Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 10/20] virtio-net: Shrink header byte swapping buffer Akihiko Odaki
2024-04-03 11:10 ` [PATCH v9 11/20] virtio-net: Disable RSS on reset Akihiko Odaki
2024-04-03 11:11 ` [PATCH v9 12/20] virtio-net: Unify the logic to update NIC state for RSS Akihiko Odaki
2024-04-03 11:11 ` [PATCH v9 13/20] virtio-net: Return an error when vhost cannot enable RSS Akihiko Odaki
2024-04-07 21:46 ` Yuri Benditovich
2024-04-08 1:29 ` Akihiko Odaki
2024-04-11 11:28 ` Yan Vugenfirer
2024-04-15 14:05 ` Yuri Benditovich
2024-04-16 4:00 ` Jason Wang
2024-04-16 5:43 ` Yuri Benditovich
2024-04-16 7:13 ` Jason Wang
2024-04-16 9:50 ` Yuri Benditovich
2024-04-17 4:18 ` Jason Wang
2024-04-16 6:54 ` Akihiko Odaki
2024-04-20 14:27 ` Yuri Benditovich
2024-04-16 9:54 ` Yuri Benditovich
2024-04-03 11:11 ` [PATCH v9 14/20] virtio-net: Report RSS warning at device realization Akihiko Odaki
2024-04-03 11:11 ` [PATCH v9 15/20] virtio-net: Always set populate_hash Akihiko Odaki
2024-04-03 11:11 ` [PATCH v9 16/20] virtio-net: Do not write hashes to peer buffer Akihiko Odaki
2024-04-07 22:09 ` Yuri Benditovich
2024-04-08 1:30 ` Akihiko Odaki [this message]
2024-04-08 7:40 ` Yuri Benditovich
2024-04-08 7:42 ` Akihiko Odaki
2024-04-08 7:54 ` Yuri Benditovich
2024-04-08 7:57 ` Akihiko Odaki
2024-04-08 8:06 ` Yuri Benditovich
2024-04-08 8:11 ` Akihiko Odaki
2024-04-03 11:11 ` [PATCH v9 17/20] ebpf: Fix RSS error handling Akihiko Odaki
2024-04-13 12:16 ` Yuri Benditovich
2024-04-14 6:36 ` Akihiko Odaki
2024-04-03 11:11 ` [PATCH v9 18/20] ebpf: Return 0 when configuration fails Akihiko Odaki
2024-04-03 11:11 ` [PATCH v9 19/20] ebpf: Refactor tun_rss_steering_prog() Akihiko Odaki
2024-04-03 11:11 ` [PATCH v9 20/20] ebpf: Add a separate target for skeleton Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8010b335-4b46-456e-bf6e-c191cdc34964@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=andrew@daynix.com \
--cc=dmitry.fleytman@gmail.com \
--cc=g.lettieri@iet.unipi.it \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rizzo@iet.unipi.it \
--cc=sriram.yagnaraman@est.tech \
--cc=v.maffione@gmail.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).