From: David Woodhouse <dwmw2@infradead.org>
To: "Babis Chalios" <bchalios@amazon.es>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: "mst@redhat.com" <mst@redhat.com>,
"imammedo@redhat.com" <imammedo@redhat.com>,
"cohuck@redhat.com" <cohuck@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, "Graf (AWS),
Alexander" <graf@amazon.de>,
"mzxreary@0pointer.de" <mzxreary@0pointer.de>
Subject: Re: [RFC PATCH 3/4] hw/acpi: add VM generation counter field to VMClock
Date: Mon, 01 Dec 2025 15:28:41 +0000 [thread overview]
Message-ID: <8011120ce85038b80d755032bb56084bf50bc2f4.camel@infradead.org> (raw)
In-Reply-To: <843dc13c2dbb2b1f0bd622fe90e388e3e0752b92.camel@amazon.es>
[-- Attachment #1: Type: text/plain, Size: 706 bytes --]
On Mon, 2025-12-01 at 16:01 +0100, Babis Chalios wrote:
>
> That's a shame :(
>
> Maybe we could do the same as VMGenID then. Make vm_generation_counter
> something that the user can set when creating the device (same as
> VMGenID's GUID). WDYT David?
Hm, can we store the current vmgenid in the vmlcock serialised state
and then bump the counter if it *changes*? Arguably we shouldn't be
advertising the VMCLOCK_FLAG_VM_GEN_COUNTER_PRESENT flag if there is no
vmgenid anyway, so we should *already* be looking at least for its
presence?
That way, when the external tooling launches the new QEMU for the
snapshot with the new vmgenid, we will spot it and bump the counter
accordingly?
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5069 bytes --]
next prev parent reply other threads:[~2025-12-01 15:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-01 12:50 [RFC PATCH 0/4] vmclock: add support for VM generation counter and notifications Chalios, Babis
2025-12-01 12:50 ` Chalios, Babis
2025-12-01 12:52 ` Babis Chalios
2025-12-01 12:50 ` [RFC PATCH 1/4] acpi: fix acpi_send_gpe_event() to handle more events Chalios, Babis
2025-12-01 12:50 ` [RFC PATCH 2/4] hw/acpi: add new fields in VMClock ABI Chalios, Babis
2025-12-01 13:04 ` Cornelia Huck
2025-12-01 13:11 ` Babis Chalios
2025-12-01 13:36 ` Cornelia Huck
2025-12-01 13:24 ` David Woodhouse
2025-12-01 13:38 ` Cornelia Huck
2025-12-01 14:27 ` David Woodhouse
2025-12-01 15:05 ` Babis Chalios
2025-12-01 15:21 ` David Woodhouse
2025-12-01 15:10 ` Cornelia Huck
2025-12-01 12:51 ` [RFC PATCH 3/4] hw/acpi: add VM generation counter field to VMClock Chalios, Babis
2025-12-01 14:12 ` Daniel P. Berrangé
2025-12-01 14:29 ` David Woodhouse
2025-12-01 14:41 ` Daniel P. Berrangé
2025-12-01 15:01 ` Babis Chalios
2025-12-01 15:28 ` David Woodhouse [this message]
2025-12-01 12:51 ` [RFC PATCH 4/4] hw/acpi: add ACPI notification to VMClock device Chalios, Babis
2025-12-01 15:10 ` [RFC PATCH 0/4] vmclock: add support for VM generation counter and notifications Daniel P. Berrangé
2025-12-01 15:23 ` David Woodhouse
2025-12-01 15:46 ` Babis Chalios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8011120ce85038b80d755032bb56084bf50bc2f4.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=bchalios@amazon.es \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=graf@amazon.de \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=mzxreary@0pointer.de \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).