From: "François Revol" <revol@free.fr>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RESEND][PATCH][RFC] usb-wacom.c merge into usb-hid.c (fwd)
Date: Tue, 31 Mar 2009 16:40:38 +0200 CEST [thread overview]
Message-ID: <8039932994-BeMail@laptop> (raw)
In-Reply-To: <200903311522.40378.paul@codesourcery.com>
> On Tuesday 31 March 2009, François Revol wrote:
> > ping ?
>
> There seem to be several unrelated name changes, and several bits of
> commented
> out code. The latter is always wrong. Disabled code just bitrots.
> Either fix
> it, or replace it with a comment describing whatever that code was
> supposed
> to indicate.
The names were different in usb-wacom (HID_GET_* instead of GET_*), and
those seemed cleaner to use. Simple :%s/// in vim.
The first commented line is due to an identical value in the case that
I wanted to advertise, and it's why it's tagged [RFC].
The other commented line is just the name of the device, I think I
was't sure which to have here, RFC too.
François.
prev parent reply other threads:[~2009-03-31 14:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-31 13:51 [Qemu-devel] [RESEND][PATCH][RFC] usb-wacom.c merge into usb-hid.c (fwd) François Revol
2009-03-31 14:22 ` Paul Brook
2009-03-31 14:40 ` François Revol [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8039932994-BeMail@laptop \
--to=revol@free.fr \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).