From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Lof8t-0006TY-1R
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 10:40:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Lof8n-0006R1-UK
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 10:40:42 -0400
Received: from [199.232.76.173] (port=55435 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Lof8n-0006Qs-F2
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 10:40:37 -0400
Received: from smtp5-g21.free.fr ([212.27.42.5]:45102)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <revol@free.fr>) id 1Lof8m-0006vj-Ks
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 10:40:37 -0400
Received: from smtp5-g21.free.fr (localhost [127.0.0.1])
	by smtp5-g21.free.fr (Postfix) with ESMTP id 7E828D481A8
	for <qemu-devel@nongnu.org>; Tue, 31 Mar 2009 16:40:32 +0200 (CEST)
Received: from laptop (vaf26-2-82-244-111-82.fbx.proxad.net [82.244.111.82])
	by smtp5-g21.free.fr (Postfix) with ESMTP id 91C1BD480FC
	for <qemu-devel@nongnu.org>; Tue, 31 Mar 2009 16:40:30 +0200 (CEST)
In-Reply-To: <200903311522.40378.paul@codesourcery.com>
Subject: Re: [Qemu-devel] [RESEND][PATCH][RFC] usb-wacom.c merge
	into	=?utf-8?q?usb-hid.c?= (fwd)
From: "=?utf-8?q?Fran=C3=A7ois?= Revol" <revol@free.fr>
Date: Tue, 31 Mar 2009 16:40:38 +0200 CEST
Message-Id: <8039932994-BeMail@laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

> On Tuesday 31 March 2009, Fran=C3=A7ois Revol wrote:
> > ping =3F
> 
> There seem to be several unrelated name changes, and several bits of 
> commented 
> out code. The latter is always wrong. Disabled code just bitrots. 
> Either fix 
> it, or replace it with a comment describing whatever that code was 
> supposed 
> to indicate.

The names were different in usb-wacom (HID=5FGET=5F* instead of GET=5F*), and 
those seemed cleaner to use. Simple :%s/// in vim.

The first commented line is due to an identical value in the case that 
I wanted to advertise, and it's why it's tagged [RFC].

The other commented line is just the name of the device, I think I 
was't sure which to have here, RFC too.

Fran=C3=A7ois.