From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/3] block/qcow*: Don't take address of fields in packed structs
Date: Tue, 9 Oct 2018 10:49:25 -0700 [thread overview]
Message-ID: <806d9a66-78bb-ab15-dbcf-b48a0ca777c4@linaro.org> (raw)
In-Reply-To: <20181009172501.17353-1-peter.maydell@linaro.org>
On 10/9/18 10:24 AM, Peter Maydell wrote:
> Peter Maydell (3):
> block/qcow2: Don't take address of fields in packed structs
> block/qcow: Don't take address of fields in packed structs
> block/qcow2-bitmap: Don't take address of fields in packed structs
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Although I do think you should put the script you used into
scripts/coccinelle/, so that it may be used for the rest of the files in the
tree. We can delete the script after those pointer-based functions are removed.
r~
next prev parent reply other threads:[~2018-10-09 17:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 17:24 [Qemu-devel] [PATCH 0/3] block/qcow*: Don't take address of fields in packed structs Peter Maydell
2018-10-09 17:24 ` [Qemu-devel] [PATCH 1/3] block/qcow2: " Peter Maydell
2018-10-09 17:25 ` [Qemu-devel] [PATCH 2/3] block/qcow: " Peter Maydell
2018-10-09 17:25 ` [Qemu-devel] [PATCH 3/3] block/qcow2-bitmap: " Peter Maydell
2018-10-09 17:49 ` Richard Henderson [this message]
2018-10-09 19:04 ` [Qemu-devel] [Qemu-block] [PATCH 0/3] block/qcow*: " John Snow
2018-10-10 10:55 ` [Qemu-devel] " Kevin Wolf
2018-11-05 14:41 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=806d9a66-78bb-ab15-dbcf-b48a0ca777c4@linaro.org \
--to=richard.henderson@linaro.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).