From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PULL_REQUEST,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 679E7C433DF for ; Mon, 3 Aug 2020 17:54:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 59AA422BEB for ; Mon, 3 Aug 2020 17:54:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XYihpLaR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59AA422BEB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2efE-0001sx-IS for qemu-devel@archiver.kernel.org; Mon, 03 Aug 2020 13:54:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42480) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2ee9-0001FH-J4 for qemu-devel@nongnu.org; Mon, 03 Aug 2020 13:53:14 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:35274 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1k2ee6-0008Bn-65 for qemu-devel@nongnu.org; Mon, 03 Aug 2020 13:53:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1596477189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=J6UCdQLyMZpsA9q68LRHRvF34DrGv4PSV/MwE39my2M=; b=XYihpLaR4SXDySpTpe0SYAIwOPfnJKv8eLBYmbv1uXbhxJlnXgt32XX/Nxd0ByZYpBHuV8 NeaZFPnSQEI+BGniINuFNeyb9f3RGM5GaU1/w6GU36o7zoJjTOnTQDTSvJbx8N9XXiAvp8 OWtXXK92qOzRXE7DyggbGv4JWExK7UQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-H0Y3StC0PSKAps1QrcU0hQ-1; Mon, 03 Aug 2020 13:53:05 -0400 X-MC-Unique: H0Y3StC0PSKAps1QrcU0hQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E082E19057BD; Mon, 3 Aug 2020 17:53:03 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-54.ams2.redhat.com [10.36.112.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67DF75FC2F; Mon, 3 Aug 2020 17:53:02 +0000 (UTC) Subject: Re: [PULL 00/63] riscv-to-apply queue To: LIU Zhiwei , Alistair Francis , Peter Maydell References: <20200626214410.3613258-1-alistair.francis@wdc.com> <544fb149-c920-b396-7297-f9688a744445@c-sky.com> <29f57b2e-7d67-5da2-0ad0-0750e400a91c@redhat.com> <67c76bac-2416-9ace-a71b-ab56b864975b@c-sky.com> From: Thomas Huth Openpgp: preference=signencrypt Message-ID: <808d1b49-c03c-6bc7-09e1-7028259bbef6@redhat.com> Date: Mon, 3 Aug 2020 19:53:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <67c76bac-2416-9ace-a71b-ab56b864975b@c-sky.com> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=205.139.110.120; envelope-from=thuth@redhat.com; helo=us-smtp-1.mimecast.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/03 13:51:25 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -30 X-Spam_score: -3.1 X-Spam_bar: --- X-Spam_report: (-3.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alistair Francis , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 30/06/2020 10.44, LIU Zhiwei wrote: > > > On 2020/6/30 16:11, Thomas Huth wrote: >> On 30/06/2020 08.56, LIU Zhiwei wrote: >>> >>> >>> On 2020/6/29 6:51, Alistair Francis wrote: >>>> On Sun, Jun 28, 2020 at 7:30 AM Peter Maydell >>>> wrote: >>>>> On Fri, 26 Jun 2020 at 22:53, Alistair Francis >>>>> wrote: >>>>>> The following changes since commit >>>>>> 553cf5d7c47bee05a3dec9461c1f8430316d516b: >>>>>> >>>>>>    Merge remote-tracking branch >>>>>> 'remotes/pmaydell/tags/pull-target-arm-20200626' into staging >>>>>> (2020-06-26 18:22:36 +0100) >>>>>> >>>>>> are available in the Git repository at: >>>>>> >>>>>>    git@github.com:alistair23/qemu.git >>>>>> tags/pull-riscv-to-apply-20200626-1 >>>>>> >>>>>> for you to fetch changes up to >>>>>> b39d59434ea10649fdb9e0a339c30c76e38c5e17: >>>>>> >>>>>>    target/riscv: configure and turn on vector extension from >>>>>> command line (2020-06-26 14:22:15 -0700) >>>>>> >>>>>> ---------------------------------------------------------------- >>>>>> This PR contains two patches to improve PLIC support in QEMU. >>>>>> >>>>>> The rest of the PR is adding support for the v0.7.1 RISC-V vector >>>>>> extensions. This is experimental support as the vector extensions are >>>>>> still in a draft state. >>>>>> >>>>> Hi; I'm afraid this fails to build on PPC64 and s390x (ie >>>>> our big-endian hosts): >>> Hi Peter, >>> >>> Do you mean you built the patch set on PPC64 or s390x and got errors >>> in the list? Or just a worry? >> > >>> I have built the patch set on Ubuntu 18.04 X86-64. I don't know which >>> compile option >>> will fails the compilation. If you compiled on Ubuntu x86-64, could >>> you show me the >>> compile option? >> >> The related code in your patch "target/riscv: add vector stride load >> and store instructions" is in a "#ifdef HOST_WORDS_BIGENDIAN" section, >> so of course this bug does not trigger on a x86 host. You could >> temporarily turn the "#ifdef HOST_WORDS_BIGENDIAN" into a "#if 1" to >> see whether you can then also reproduce the error on x86. >> > Yes. I can reproduce it in this way. >>> As a note: I try to find a PPC64 for test, but I'm afraid it will be >>> too later. >>> Is there an available  PPC64  machine in the community? >> >> Maybe the easiest way to test your code on a big endian machine, too, >> is to get a github account, clone the QEMU repository there, and >> enable Travis for that repo. Then your code gets built on some non-x86 >> architectures (including a big-endian s390x) as soon as you push it to >> the repo (see .travis.yml for details). >> > Thanks very much. I will have a try. >>>>> /home/ubuntu/qemu/target/riscv/vector_helper.c: In function >>>>> ‘vext_clear’: >>>>> /home/ubuntu/qemu/target/riscv/vector_helper.c: In function >>>>> ‘vext_clear’: >>>>> /home/ubuntu/qemu/target/riscv/vector_helper.c:154:21: error: invalid >>>>> operands to binary & (have ‘void *’ and ‘long long unsigned int’) >>>>>           memset(tail & ~(7ULL), 0, part1); >> >> You obviously must not use "&" with a pointer. I guess you have to >> cast to "uintptr_t" and back, or think of some other smart way to fix >> this. >> > Yes. That's the error. It  build successfully after the cast. I'm sorry, but the new code fails to compile on big endian 32-bit targets, see https://gitlab.com/huth/qemu/-/jobs/667762754#L3434 : /builds/huth/qemu/target/riscv/vector_helper.c: In function 'vext_clear': /builds/huth/qemu/target/riscv/vector_helper.c:154:16: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] memset((void *)((uintptr_t)tail & ~(7ULL)), 0, part1); ^ /builds/huth/qemu/target/riscv/vector_helper.c:155:16: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] memset((void *)(((uintptr_t)tail + 8) & ~(7ULL)), 0, part2); ^ cc1: all warnings being treated as errors A quick work-around is maybe to replace "ULL" with simply "UL" ? Thomas