From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Phil Dennis-Jordan" <phil@philjordan.eu>,
"Pierrick Bouvier" <pierrick.bouvier@linaro.org>,
"Mads Ynddal" <mads@ynddal.dk>,
"Alexander Graf" <agraf@csgraf.de>,
"Cameron Esfahani" <dirty@apple.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Roman Bolshakov" <rbolshakov@ddn.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-arm@nongnu.org,
"Manos Pitsidianakis" <manos.pitsidianakis@linaro.org>
Subject: Re: [PATCH 4/4] accel/tcg: Use cpu_is_stopped() helper to access CPUState::stopped
Date: Thu, 25 Sep 2025 17:44:08 -0700 [thread overview]
Message-ID: <80a57c75-cd17-42e4-a678-aaadb6a47a92@linaro.org> (raw)
In-Reply-To: <20250925025520.71805-5-philmd@linaro.org>
On 9/24/25 19:55, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
> accel/tcg/tcg-accel-ops-rr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c
> index 2fb46439971..f84342e0449 100644
> --- a/accel/tcg/tcg-accel-ops-rr.c
> +++ b/accel/tcg/tcg-accel-ops-rr.c
> @@ -197,7 +197,7 @@ static void *rr_cpu_thread_fn(void *arg)
> qemu_guest_random_seed_thread_part2(cpu->random_seed);
>
> /* wait for initial kick-off after machine start */
> - while (first_cpu->stopped) {
> + while (cpu_is_stopped(first_cpu)) {
> qemu_cond_wait_bql(first_cpu->halt_cond);
>
> /* process any pending work */
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
prev parent reply other threads:[~2025-09-26 0:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-25 2:55 [PATCH 0/4] cpus: Cleanups around cpu running state changes Philippe Mathieu-Daudé
2025-09-25 2:55 ` [PATCH 1/4] cpus: Only resume halted CPUs Philippe Mathieu-Daudé
2025-09-25 8:34 ` Philippe Mathieu-Daudé
2025-09-25 2:55 ` [PATCH 2/4] cpus: Access CPUState::thread_kicked atomically Philippe Mathieu-Daudé
2025-09-29 5:52 ` Manos Pitsidianakis
2025-09-25 2:55 ` [PATCH 3/4] accel/hvf: Make async_safe_run_on_cpu() safe Philippe Mathieu-Daudé
2025-09-26 0:13 ` Richard Henderson
2025-09-25 2:55 ` [PATCH 4/4] accel/tcg: Use cpu_is_stopped() helper to access CPUState::stopped Philippe Mathieu-Daudé
2025-09-26 0:44 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80a57c75-cd17-42e4-a678-aaadb6a47a92@linaro.org \
--to=richard.henderson@linaro.org \
--cc=agraf@csgraf.de \
--cc=alex.bennee@linaro.org \
--cc=dirty@apple.com \
--cc=mads@ynddal.dk \
--cc=manos.pitsidianakis@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=philmd@linaro.org \
--cc=pierrick.bouvier@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rbolshakov@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).