From: Richard Henderson <richard.henderson@linaro.org>
To: Paolo Bonzini <pbonzini@redhat.com>,
Peter Foley <pefoley@google.com>,
qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>, nabihestefan@google.com
Subject: Re: [PATCH] linux-user: Add missing includes
Date: Fri, 5 Sep 2025 10:48:55 +0200 [thread overview]
Message-ID: <80ba3dae-0bb9-4a45-b1f9-5b80f4fdc47b@linaro.org> (raw)
In-Reply-To: <687f76dc-769d-4e8d-9281-5e5f10361bfe@redhat.com>
On 9/5/25 09:31, Paolo Bonzini wrote:
> On 9/4/25 17:21, Peter Foley wrote:
>> We're getting errors about this:
>> linux-user/elfload.c:2770:36: error: use of undeclared identifier 'MAP_FIXED_NOREPLACE'
>
> Queued, thanks.
>
> Paolo
>
>>
>> Signed-off-by: Peter Foley <pefoley@google.com>
>> ---
>> linux-user/elfload.c | 1 +
>> linux-user/mmap.c | 1 +
>> linux-user/syscall.c | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/linux-user/elfload.c b/linux-user/elfload.c
>> index 26c090c95d3e90ad4a23a927267e4106f68975b0..edbacf041f25d88472c95efb4eb9bdccd81e9902
>> 100644
>> --- a/linux-user/elfload.c
>> +++ b/linux-user/elfload.c
>> @@ -5,6 +5,7 @@
>> #include <sys/prctl.h>
>> #include <sys/resource.h>
>> #include <sys/shm.h>
>> +#include <linux/mman.h>
There's no reason to include <linux/mman.h>.
This value is provided by <sys/mman.h> directly for musl and by <sys/mman.h> via
<bits/mman-map-flags*> for glibc.
Are you using some other libc? You're solidly in non-standard territory there.
Perhaps that other libc needs updating.
r~
next prev parent reply other threads:[~2025-09-05 8:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-04 15:21 [PATCH] linux-user: Add missing includes Peter Foley
2025-09-05 7:31 ` Paolo Bonzini
2025-09-05 8:48 ` Richard Henderson [this message]
2025-09-05 16:00 ` Peter Foley
2025-09-05 16:06 ` Peter Foley
2025-09-05 16:26 ` Richard Henderson
2025-09-05 16:28 ` Peter Foley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80ba3dae-0bb9-4a45-b1f9-5b80f4fdc47b@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=nabihestefan@google.com \
--cc=pbonzini@redhat.com \
--cc=pefoley@google.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).