From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C826D735F3 for ; Sat, 30 Nov 2024 06:18:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHGnp-0008QQ-GF; Sat, 30 Nov 2024 01:18:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHGmP-0007fO-H5 for qemu-devel@nongnu.org; Sat, 30 Nov 2024 01:16:35 -0500 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHGmN-0002xN-Bz for qemu-devel@nongnu.org; Sat, 30 Nov 2024 01:16:33 -0500 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-2154e3af730so7511355ad.3 for ; Fri, 29 Nov 2024 22:16:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20230601.gappssmtp.com; s=20230601; t=1732947389; x=1733552189; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=iAADfka+wJ/6sNT0BcTzF7GinB4EOzBtyw1Ynff8yIo=; b=Pl49k1B7pvKog+SXw0l3/mK8xGj3Z+Gw5RyCPUF/V4Ts6517lZyARrLfSdssUNrD/u +ELOuVOivEG8kDuFuUWoA8i7G94wY0pbzocnMNwS11PnZuWJrS+ybGdMdpb9n6J0dx7v basYQOxYiY4PvAVMPRTUE8DOy+d8jP5I1OiGb3RcsvV+FyG/gJmi9SVHvhF1Kx7ZKDDy G1xypxl+J4IIxT0hPRxs5SSRJnIGn/DZW/j2g7xKaIEYMcCJacHeAEltnvL5qlEuISIg MpiKUcN6p2LBBbi8awUR0WO6A8PrLNIqKxwPHTTaC7FFWxtb8Llb6bK2dAKqn0h2fdQU jFxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732947389; x=1733552189; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iAADfka+wJ/6sNT0BcTzF7GinB4EOzBtyw1Ynff8yIo=; b=EkgNnTTH4tKH2aAnpQaSIuxToOjwCjfeyurp8PV8T/PeU9JwgFW3lHfTkyBtBayIgk 3pAnSwORiXUlhfSxwusvS38xE+nMusIi2Dmg8adcmzJpDIuDOesVV4zVa88NY8Ak3BId gO7hc9cDz6KSHzOGsoEgrWo40EZTd4iNXKVQJTouw/PFdqB0WSxWpKIfJ3MiXq+Cht9W ybNpbPmS2puxGGp0izPvwAv7uk4ObDJDKad+cPuBhAxjctnMlnrftOi3akhbj1mqVdS+ 4gH40Tr+3TDLmMMNj+WzglkwlDTOSRd6NZO6B9Gt+c94qSYDR/6+KQgbyVLqfaqS4f5a 6OaQ== X-Forwarded-Encrypted: i=1; AJvYcCVfPtHpGnzqJwKSGH1kPyTchrpuw/5ene2V69K5krgTf+JwmWvE6syFvW+pm9Gm/zJRYFuB3nAxbBNR@nongnu.org X-Gm-Message-State: AOJu0YxDRjDPdKJfgbZRh29RzUOx2cfjh1qTD65zrHpmHvvid4w1+iu/ 58wTWWAn6dWR7Lv6nFI+SU0BXrsm4cx1I9pDUx1FOEma7kRISfdwAZN7rHuSKoE= X-Gm-Gg: ASbGncuCEk6+sdGszUWKw+sB7zcPVVoSxol2N9kI6JeT1IASUiFmGjjLhzWq9q7cefq wM5tLKT/Sd/vOGJkMZl2HhML6LQ1yDXDfG4Ztnjk0dqSmaK7bihLfHDMaXH9xygQt8mNn9iDH16 s8kzlDZS7TlrtnF60mJFret5wfJ3KHTYdDnSVZRMVLEJX8p3jlyNTxmYFrvewNhX5bR3j2pi+s2 zXHmuvleVmBLZYqP00Rmk8S8q+otzVhXu5r3EDDgG/TaAhbRVOMypJBfOadgQs= X-Google-Smtp-Source: AGHT+IGaaoWFFFzAjAjsqvjmMY9EtET2q2/bw/RllNwXGeAO7t4Hw/9L3k4/iRSduOdhpfyIlhsbGw== X-Received: by 2002:a17:902:cec1:b0:20b:5b1a:209 with SMTP id d9443c01a7336-2150108cac1mr201300605ad.9.1732947389627; Fri, 29 Nov 2024 22:16:29 -0800 (PST) Received: from [157.82.207.167] ([157.82.207.167]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2154be15034sm15955885ad.205.2024.11.29.22.16.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Nov 2024 22:16:29 -0800 (PST) Message-ID: <80bc3a21-9b0a-422e-a6dd-c58d39c7441f@daynix.com> Date: Sat, 30 Nov 2024 15:16:22 +0900 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v12 10/15] hw/vmapple/aes: Introduce aes engine To: Phil Dennis-Jordan , qemu-devel@nongnu.org Cc: agraf@csgraf.de, peter.maydell@linaro.org, pbonzini@redhat.com, rad@semihalf.com, quic_llindhol@quicinc.com, stefanha@redhat.com, mst@redhat.com, slp@redhat.com, richard.henderson@linaro.org, eduardo@habkost.net, marcel.apfelbaum@gmail.com, gaosong@loongson.cn, jiaxun.yang@flygoat.com, chenhuacai@kernel.org, kwolf@redhat.com, hreitz@redhat.com, philmd@linaro.org, shorne@gmail.com, palmer@dabbelt.com, alistair.francis@wdc.com, bmeng.cn@gmail.com, liwei1518@gmail.com, dbarboza@ventanamicro.com, zhiwei_liu@linux.alibaba.com, jcmvbkbc@gmail.com, marcandre.lureau@redhat.com, berrange@redhat.com, qemu-arm@nongnu.org, qemu-block@nongnu.org, qemu-riscv@nongnu.org, balaton@eik.bme.hu, Alexander Graf References: <20241129152506.59390-1-phil@philjordan.eu> <20241129152506.59390-11-phil@philjordan.eu> Content-Language: en-US From: Akihiko Odaki In-Reply-To: <20241129152506.59390-11-phil@philjordan.eu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=akihiko.odaki@daynix.com; helo=mail-pl1-x62b.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2024/11/30 0:25, Phil Dennis-Jordan wrote: > From: Alexander Graf > > VMApple contains an "aes" engine device that it uses to encrypt and > decrypt its nvram. It has trivial hard coded keys it uses for that > purpose. > > Add device emulation for this device model. > > Signed-off-by: Alexander Graf > Signed-off-by: Phil Dennis-Jordan > Reviewed-by: Akihiko Odaki Tested-by: Akihiko Odaki