qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Song Gao <gaosong@loongson.cn>, qemu-devel@nongnu.org
Subject: Re: [RFC PATCH v4 00/44] Add LoongArch LSX instructions
Date: Thu, 4 May 2023 09:25:53 +0100	[thread overview]
Message-ID: <80c6ed35-1d19-eb6a-0e3b-6fbf23d8540c@linaro.org> (raw)
In-Reply-To: <b6243a8d-8ef6-7609-b71c-fd3cddb69d67@loongson.cn>

On 5/4/23 02:26, Song Gao wrote:
>>> V4:
>>>    - R-b and rebase;
>>>    - Migrate the upper half lsx regs;
>>>    - Remove tcg_gen_mulus2_*;
>>>    - Vsetallnez use !do_match2;
>>>    - Use tcg_gen_concat_i64_i128/tcg_gen_extr_i128_i64 to replace
>>>      TCGV128_LOW(val)/TCGV128_High(val);
>>
>> One minor nit, everything reviewed!  Congratulations.
>>
> Thank you for your guidance and review.
> 
> Since all patches are reviewed, how about drop 'RFC' on v5?

Sure.

> I am  really not sure When the Vol2 will be open.

That is unfortunate.

I think the timing of the merge of this code is now up to you as maintainer of the 
Loongson target.  As an employee of the company you have more insight into the status of 
the extension, whether it is already present in shipping silicon, or completed final 
draft, or still beta, etc.

Even if the extension is finalized, I see no reason why you should not be able to merge, 
so long as the extension is off by default, to be enabled by a cpu property from the 
command-line.  We regularly do this for unratified RISCV extensions.


r~


  reply	other threads:[~2023-05-04  8:26 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-25  7:02 [RFC PATCH v4 00/44] Add LoongArch LSX instructions Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 01/44] target/loongarch: Add LSX data type VReg Song Gao
2023-05-01 18:33   ` Richard Henderson
2023-04-25  7:02 ` [RFC PATCH v4 02/44] target/loongarch: meson.build support build LSX Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 03/44] target/loongarch: Add CHECK_SXE maccro for check LSX enable Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 04/44] target/loongarch: Implement vadd/vsub Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 05/44] target/loongarch: Implement vaddi/vsubi Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 06/44] target/loongarch: Implement vneg Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 07/44] target/loongarch: Implement vsadd/vssub Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 08/44] target/loongarch: Implement vhaddw/vhsubw Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 09/44] target/loongarch: Implement vaddw/vsubw Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 10/44] target/loongarch: Implement vavg/vavgr Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 11/44] target/loongarch: Implement vabsd Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 12/44] target/loongarch: Implement vadda Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 13/44] target/loongarch: Implement vmax/vmin Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 14/44] target/loongarch: Implement vmul/vmuh/vmulw{ev/od} Song Gao
2023-05-01 18:34   ` Richard Henderson
2023-04-25  7:02 ` [RFC PATCH v4 15/44] target/loongarch: Implement vmadd/vmsub/vmaddw{ev/od} Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 16/44] target/loongarch: Implement vdiv/vmod Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 17/44] target/loongarch: Implement vsat Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 18/44] target/loongarch: Implement vexth Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 19/44] target/loongarch: Implement vsigncov Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 20/44] target/loongarch: Implement vmskltz/vmskgez/vmsknz Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 21/44] target/loongarch: Implement LSX logic instructions Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 22/44] target/loongarch: Implement vsll vsrl vsra vrotr Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 23/44] target/loongarch: Implement vsllwil vextl Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 24/44] target/loongarch: Implement vsrlr vsrar Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 25/44] target/loongarch: Implement vsrln vsran Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 26/44] target/loongarch: Implement vsrlrn vsrarn Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 27/44] target/loongarch: Implement vssrln vssran Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 28/44] target/loongarch: Implement vssrlrn vssrarn Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 29/44] target/loongarch: Implement vclo vclz Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 30/44] target/loongarch: Implement vpcnt Song Gao
2023-05-01 18:35   ` Richard Henderson
2023-04-25  7:02 ` [RFC PATCH v4 31/44] target/loongarch: Implement vbitclr vbitset vbitrev Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 32/44] target/loongarch: Implement vfrstp Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 33/44] target/loongarch: Implement LSX fpu arith instructions Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 34/44] target/loongarch: Implement LSX fpu fcvt instructions Song Gao
2023-05-01 18:38   ` Richard Henderson
2023-04-25  7:02 ` [RFC PATCH v4 35/44] target/loongarch: Implement vseq vsle vslt Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 36/44] target/loongarch: Implement vfcmp Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 37/44] target/loongarch: Implement vbitsel vset Song Gao
2023-05-01 18:39   ` Richard Henderson
2023-04-25  7:02 ` [RFC PATCH v4 38/44] target/loongarch: Implement vinsgr2vr vpickve2gr vreplgr2vr Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 39/44] target/loongarch: Implement vreplve vpack vpick Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 40/44] target/loongarch: Implement vilvl vilvh vextrins vshuf Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 41/44] target/loongarch: Implement vld vst Song Gao
2023-05-01 18:41   ` Richard Henderson
2023-04-25  7:02 ` [RFC PATCH v4 42/44] target/loongarch: Implement vldi Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 43/44] target/loongarch: Use {set/get}_gpr replace to cpu_fpr Song Gao
2023-04-25  7:02 ` [RFC PATCH v4 44/44] target/loongarch: CPUCFG support LSX Song Gao
2023-05-01 18:43 ` [RFC PATCH v4 00/44] Add LoongArch LSX instructions Richard Henderson
2023-05-04  1:26   ` Song Gao
2023-05-04  8:25     ` Richard Henderson [this message]
2023-05-04  9:41       ` Richard Henderson
2023-05-04 11:33         ` Song Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80c6ed35-1d19-eb6a-0e3b-6fbf23d8540c@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=gaosong@loongson.cn \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).