Re: [RFC PATCH v4 4/4] tests/avocado: Add test for amigaone board

[Thomas Huth <thuth@redhat.com>]

Please add a short patch description if this moves from RFC to a real patch

On 17/10/2023 21.06, BALATON Zoltan wrote:
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> I have no idea if this works so testing and corrections are welcome

Why don't you test it on your own? I think this should be sufficient:

  make check-avocado AVOCADO_TAGS=machine:amigaone

> but this could be a basic test. Booting further is a bit more involved
> as we'd need alternative VGA BIOS and selecting menu items in the
> firmware to allow CD boot so I did not try to automate that.
> 
> This could be simpler if the u-boot-amigaone.bin could be added to
> pc-bios. It's GPL so should be OK to include and distribute but irs
> sources seem to be lost and could not be recovered or reconstructed so
> we only have this binary. Who should be able to decide about that?

I'm sorry, but if the sources are not available anymore, then I think it 
will not be possible to ship the binary in the QEMU tarball - since the GPL 
requires that the distributor of the binary can also provide the sources on 
request.

  Thomas