qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Michael Tokarev <mjt@tls.msk.ru>, qemu-devel@nongnu.org
Cc: Hao Wu <wuhaotsh@google.com>,
	Havard Skinnemoen <hskinnemoen@google.com>,
	 Jamin Lin <jamin_lin@aspeedtech.com>
Subject: Re: [PATCH for 10.1 2/2] roms/Makefile: build ast27x0_bootrom
Date: Tue, 29 Jul 2025 09:58:10 +0200	[thread overview]
Message-ID: <80ce73e7-d6ce-4e20-b902-dfb3d4c58065@linaro.org> (raw)
In-Reply-To: <607a943a587248fbe0ff0897de80aee98a093caa.1753654515.git.mjt@tls.msk.ru>

On 28/7/25 00:19, Michael Tokarev wrote:
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3052
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
>   roms/Makefile | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/roms/Makefile b/roms/Makefile
> index 6af68a922f..2691b935c4 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -68,6 +68,7 @@ default help:
>   	@echo "  u-boot.sam460      -- update u-boot.sam460"
>   	@echo "  npcm7xx_bootrom    -- update vbootrom for npcm7xx"
>   	@echo "  npcm8xx_bootrom    -- update vbootrom for npcm8xx"
> +	@echo "  ast27x0_bootrom    -- update vbootrom for ast27x0"
>   	@echo "  efi                -- update UEFI (edk2) platform firmware"
>   	@echo "  opensbi32-generic  -- update OpenSBI for 32-bit generic machine"
>   	@echo "  opensbi64-generic  -- update OpenSBI for 64-bit generic machine"
> @@ -200,6 +201,10 @@ npcm8xx_bootrom:
>   	$(MAKE) -C vbootrom/npcm8xx CROSS_COMPILE=$(aarch64_cross_prefix)
>   	cp vbootrom/npcm8xx/npcm8xx_bootrom.bin ../pc-bios/npcm8xx_bootrom.bin
>   
> +ast27x0_bootrom:
> +	$(MAKE) -C vbootrom/ast27x0 CROSS_COMPILE=$(aarch64_cross_prefix) CC='$$(CROSS_COMPILE)gcc'
> +	cp vbootrom/ast27x0/ast27x0_bootrom.bin ../pc-bios/ast27x0_bootrom.bin

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Tested-by: Philippe Mathieu-Daudé <philmd@linaro.org>

(I only tested the bootrom builds).


      reply	other threads:[~2025-07-29  7:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-27 22:19 [PATCH for 10.1 1/2] roms/vbootrom: update to 601d410 Michael Tokarev
2025-07-27 22:19 ` [PATCH for 10.1 2/2] roms/Makefile: build ast27x0_bootrom Michael Tokarev
2025-07-29  7:58   ` Philippe Mathieu-Daudé [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80ce73e7-d6ce-4e20-b902-dfb3d4c58065@linaro.org \
    --to=philmd@linaro.org \
    --cc=hskinnemoen@google.com \
    --cc=jamin_lin@aspeedtech.com \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=wuhaotsh@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).