From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Subject: Re: [PATCH v3 07/17] target/loongarch: Add parameter mmu_context with loongarch_page_table_walker
Date: Fri, 25 Jul 2025 15:31:46 -1000 [thread overview]
Message-ID: <80d713a5-a696-47e5-ade3-fce9472daf1f@linaro.org> (raw)
In-Reply-To: <20250725013739.994437-8-maobibo@loongson.cn>
On 7/24/25 15:37, Bibo Mao wrote:
> @@ -191,8 +187,7 @@ static int loongarch_map_address(CPULoongArchState *env, hwaddr *physical,
> * legal mapping, even if the mapping is not yet in TLB. return 0 if
> * there is a valid map, else none zero.
> */
> - return loongarch_page_table_walker(env, physical, prot, address,
> - access_type, mmu_idx);
> + return loongarch_page_table_walker(env, &context, access_type, mmu_idx);
> }
You haven't stored to the physical/prot arguments to loongarch_map_address. I'm sure this
gets fixed somewhere in patches 7 through 11, but it means that this patch set isn't
bisectable.
It *might* be easier to start from the other end of the call stack.
Then you can do things like
return loongarch_page_table_walker(env, &context->physical, &context->prot, etc)
in the intermediate steps.
r~
next prev parent reply other threads:[~2025-07-26 1:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 1:37 [PATCH v3 00/17] target/loongarch: Enhancement about tcg mmu Bibo Mao
2025-07-25 1:37 ` [PATCH v3 01/17] target/loongarch: Move some function definition to kvm directory Bibo Mao
2025-07-25 23:37 ` Richard Henderson
2025-07-25 1:37 ` [PATCH v3 02/17] target/loongarch: Define function loongarch_cpu_post_init as static Bibo Mao
2025-07-25 23:38 ` Richard Henderson
2025-07-25 1:37 ` [PATCH v3 03/17] target/loongarch: Set page size in TLB misc with STLB Bibo Mao
2025-07-25 1:37 ` [PATCH v3 04/17] target/loongarch: Add header file cpu-mmu.h Bibo Mao
2025-07-26 1:10 ` Richard Henderson
2025-07-26 1:16 ` Richard Henderson
2025-07-28 3:08 ` Bibo Mao
2025-07-25 1:37 ` [PATCH v3 05/17] target/loongarch: Add common function loongarch_check_pte() Bibo Mao
2025-07-26 1:19 ` Richard Henderson
2025-07-28 3:15 ` Bibo Mao
2025-07-28 5:07 ` Richard Henderson
2025-07-25 1:37 ` [PATCH v3 06/17] target/loongarch: Use loongarch_check_pte() with page table walking Bibo Mao
2025-07-26 1:20 ` Richard Henderson
2025-07-25 1:37 ` [PATCH v3 07/17] target/loongarch: Add parameter mmu_context with loongarch_page_table_walker Bibo Mao
2025-07-26 1:31 ` Richard Henderson [this message]
2025-07-28 3:16 ` Bibo Mao
2025-07-25 1:37 ` [PATCH v3 08/17] target/loongarch: Add parameter mmu_context with loongarch_map_tlb_entry Bibo Mao
2025-07-25 1:37 ` [PATCH v3 09/17] target/loongarch: Add parameter mmu_context with loongarch_get_addr_from_tlb Bibo Mao
2025-07-25 1:37 ` [PATCH v3 10/17] target/loongarch: Add parameter mmu_context with loongarch_map_address Bibo Mao
2025-07-25 1:37 ` [PATCH v3 11/17] target/loongarch: Add parameter mmu_context with get_physical_address Bibo Mao
2025-07-25 1:37 ` [PATCH v3 12/17] target/loongarch: Track user mode address accessed in kernel mode Bibo Mao
2025-07-25 1:37 ` [PATCH v3 13/17] target/loongarch: Use correct address when flush tlb Bibo Mao
2025-07-26 1:45 ` Richard Henderson
2025-07-28 3:22 ` Bibo Mao
2025-07-28 5:09 ` Richard Henderson
2025-07-28 6:05 ` Bibo Mao
2025-07-25 1:37 ` [PATCH v3 14/17] target/loongarch: Use mmu idx bitmap method " Bibo Mao
2025-07-25 1:47 ` [PATCH v3 15/17] target/loongarch: Add parameter tlb pointer with fill_tlb_entry Bibo Mao
2025-07-26 1:47 ` Richard Henderson
2025-07-25 1:47 ` [PATCH v3 16/17] target/loongarch: Reduce TLB flush with helper_tlbwr Bibo Mao
2025-07-25 1:48 ` [PATCH v3 17/17] target/loongarch: Update TLB index selection method Bibo Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80d713a5-a696-47e5-ade3-fce9472daf1f@linaro.org \
--to=richard.henderson@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).