[PATCH] .gitlab-ci.d/buildtest.yml: Install 'file' for the Coverity job

[PATCH] .gitlab-ci.d/buildtest.yml: Install 'file' for the Coverity job

[Peter Maydell]

The coverity-scan upload job has started failing as of 30th
September:

[ERROR] Cannot find '/usr/bin/file' command, and no 'file' command is found in the PATH
        Coverity Capture uses this tool to identify the file type of executables.
        Please ensure '/usr/bin/file' is available, or add the 'file' utility to your PATH.

This seems to have broken when we moved our containers from Fedora 40
to 41 -- probably F40 indirectly pulled in 'file' via some other
dependency, but in F41 it does not.

Explicitly install 'file' for the coverity job, in the same way we
already do for curl and wget.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I don't know any way to test this except by applying it and letting the
coverity job run when it hits upstream git... Possibly we might find that
it complains about some other missing dependency and we need to iterate
on this.
---
 .gitlab-ci.d/buildtest.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 0502094b9aa..21f6d7e96fe 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -759,7 +759,7 @@ coverity:
     - job: amd64-fedora-container
       optional: true
   before_script:
-    - dnf install -y curl wget
+    - dnf install -y curl wget file
   script:
     # would be nice to cancel the job if over quota (https://gitlab.com/gitlab-org/gitlab/-/issues/256089)
     # for example:
-- 
2.43.0

Re: [PATCH] .gitlab-ci.d/buildtest.yml: Install 'file' for the Coverity job

[Philippe Mathieu-Daudé]

On 17/10/25 15:31, Peter Maydell wrote:
> The coverity-scan upload job has started failing as of 30th
> September:
> 
> [ERROR] Cannot find '/usr/bin/file' command, and no 'file' command is found in the PATH
>          Coverity Capture uses this tool to identify the file type of executables.
>          Please ensure '/usr/bin/file' is available, or add the 'file' utility to your PATH.
> 
> This seems to have broken when we moved our containers from Fedora 40
> to 41 -- probably F40 indirectly pulled in 'file' via some other
> dependency, but in F41 it does not.
> 
> Explicitly install 'file' for the coverity job, in the same way we
> already do for curl and wget.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I don't know any way to test this except by applying it and letting the
> coverity job run when it hits upstream git... Possibly we might find that
> it complains about some other missing dependency and we need to iterate
> on this.
> ---
>   .gitlab-ci.d/buildtest.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH] .gitlab-ci.d/buildtest.yml: Install 'file' for the Coverity job

[Richard Henderson]

On 10/17/25 06:31, Peter Maydell wrote:
> The coverity-scan upload job has started failing as of 30th
> September:
> 
> [ERROR] Cannot find '/usr/bin/file' command, and no 'file' command is found in the PATH
>          Coverity Capture uses this tool to identify the file type of executables.
>          Please ensure '/usr/bin/file' is available, or add the 'file' utility to your PATH.
> 
> This seems to have broken when we moved our containers from Fedora 40
> to 41 -- probably F40 indirectly pulled in 'file' via some other
> dependency, but in F41 it does not.
> 
> Explicitly install 'file' for the coverity job, in the same way we
> already do for curl and wget.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I don't know any way to test this except by applying it and letting the
> coverity job run when it hits upstream git... Possibly we might find that
> it complains about some other missing dependency and we need to iterate
> on this.
> ---
>   .gitlab-ci.d/buildtest.yml | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Applied to master.


r~

Re: [PATCH] .gitlab-ci.d/buildtest.yml: Install 'file' for the Coverity job

[Peter Maydell]

On Fri, 17 Oct 2025 at 14:31, Peter Maydell <peter.maydell@linaro.org> wrote:
>
> The coverity-scan upload job has started failing as of 30th
> September:
>
> [ERROR] Cannot find '/usr/bin/file' command, and no 'file' command is found in the PATH
>         Coverity Capture uses this tool to identify the file type of executables.
>         Please ensure '/usr/bin/file' is available, or add the 'file' utility to your PATH.
>
> This seems to have broken when we moved our containers from Fedora 40
> to 41 -- probably F40 indirectly pulled in 'file' via some other
> dependency, but in F41 it does not.
>
> Explicitly install 'file' for the coverity job, in the same way we
> already do for curl and wget.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I don't know any way to test this except by applying it and letting the
> coverity job run when it hits upstream git... Possibly we might find that
> it complains about some other missing dependency and we need to iterate
> on this.

Happily, this does seem to have been sufficient, and the job has
now passed and Coverity has completed a scan.

-- PMM