From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Rafael Kitover" <rkitover@gmail.com>
Subject: Re: [PATCH] meson: move pixman detection to meson
Date: Thu, 27 Aug 2020 09:28:14 +0200 [thread overview]
Message-ID: <80f0ce6c-0bc3-42c5-523c-f81f997a5ab5@redhat.com> (raw)
In-Reply-To: <CABgObfYJ=6fRSzTz5C1A8dgbom7-QWtn1J1L7-8+4thkxNTvjA@mail.gmail.com>
On 27/08/2020 08.14, Paolo Bonzini wrote:
>
>
> Il gio 27 ago 2020, 06:53 Thomas Huth <thuth@redhat.com
> <mailto:thuth@redhat.com>> ha scritto:
>
> > -else
> > - error_exit "pixman >= 0.21.8 not present." \
> > - "Please install the pixman devel package."
> > -fi
>
> The "else" part now got completely lost, didn't it?
>
>
> It's replaced by "required: have_system" in meson.build. We can add a
> custom "not found" message, but if the current one is not enough we
> should improve Meson so that it figures out a good one from the version
> requirement.
Ah, now it makes sense, thanks for the explanation!
But I've tested the patch now, and it does not work:
.../qemu/meson.build:117:3: ERROR: Unknown variable "have_system".
Should the pixman test maybe be moved to a later spot in the file? It
currently shows up before the have_system variable is initialized...
Thomas
next prev parent reply other threads:[~2020-08-27 7:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 7:02 [PATCH] meson: move pixman detection to meson Paolo Bonzini
2020-08-27 4:52 ` Thomas Huth
2020-08-27 6:14 ` Paolo Bonzini
2020-08-27 7:28 ` Thomas Huth [this message]
2020-08-27 8:19 ` Paolo Bonzini
2020-08-27 8:28 ` Thomas Huth
2020-08-30 13:31 ` Stefan Weil
2020-08-30 15:39 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80f0ce6c-0bc3-42c5-523c-f81f997a5ab5@redhat.com \
--to=thuth@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkitover@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).