From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E03B2C4338F for ; Sat, 7 Aug 2021 08:15:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 040D960EB2 for ; Sat, 7 Aug 2021 08:15:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 040D960EB2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:57254 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCHUC-0006mb-S5 for qemu-devel@archiver.kernel.org; Sat, 07 Aug 2021 04:15:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50304) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCHT0-0005N9-1h; Sat, 07 Aug 2021 04:14:02 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]:38775) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mCHSy-00068v-4S; Sat, 07 Aug 2021 04:14:01 -0400 Received: by mail-wr1-x429.google.com with SMTP id l18so14128719wrv.5; Sat, 07 Aug 2021 01:13:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=0EgP5djFeKOy8mbp7NNVDG7L8XkGr3rfIgBFUBT4T+U=; b=dBTLatOJGHgqHvUIVbMqSXOEY52GdQKz+A8Qdzx6ckyyG7k3pc3g0JgKGv3ynRbKUo qtD9e2k09amc/Gj+sg6j5vWlPTn6PcF0FtPvkvsx+rX+wXnOQ6quCGhANRry8aVHU4Cm ebt3zqXUT0fHuYfLWE8riu17DXRYPjr909fW5Q7vAdBuJ6ztQd2Kp4Ny5B+rRYJJ4UFD j3Zl+Xcae08XuHkUAbQc7kYdO77nSJyeK8lCGUEqkxxm7Sgw26XppQJYRo8w7naGBMNc aPazXv5dbafOwdRHRqeqaZdwGvNttvOUTR5VnRVdiAc/DvQKIs00TEOejRpcbF7s5svr nGfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=0EgP5djFeKOy8mbp7NNVDG7L8XkGr3rfIgBFUBT4T+U=; b=D1MmOe+cyIIg/kVTX1kyWoZ7zar9rCrtZOByXwq+vdL12kvUunWpPJ+O9+DGuoV25k /3H2/tihcw+ZCPnAvZBh0CV9kpmEbTMtbUg230gfJGFLP5t27RMND1FXAwaCf3U4piU3 IwxAwZUicxRs8ugp0M8ZyG1bnhU7rEUREtXysITrfWzT/jEWmumvyzXeZqyHZBMqM6Fw VGenujRmPq5okyHvxgV3gVK7lfcrIL2f4VjEp6lU4Ap796sB/GCT+Tr+7LEldxDH2DNj 3siOcvmNL4TvqLuucc4K4CfFYJ1JXA1Zg3dKiFVdRrHVF0TzF7UK8yO07+uyewmg7Jn6 AVIg== X-Gm-Message-State: AOAM530gXr99mtHu4NyR2Rov4BuIPvLj69Qmp1fK8p6ms6hlXtPbYoIg 6sd22db5O1V1Obd3QUYyUic= X-Google-Smtp-Source: ABdhPJyUGi3A9hE4Y77bKS5WlxcrLeJdL5JGcUmCVVOTZNnh+QkX4ADdo6RNL41dT7kg7ZWKkPCQLA== X-Received: by 2002:a5d:4b48:: with SMTP id w8mr15049507wrs.109.1628324037251; Sat, 07 Aug 2021 01:13:57 -0700 (PDT) Received: from [192.168.1.36] (163.red-83-52-55.dynamicip.rima-tde.net. [83.52.55.163]) by smtp.gmail.com with ESMTPSA id x16sm12265650wru.40.2021.08.07.01.13.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 07 Aug 2021 01:13:56 -0700 (PDT) Subject: Re: [PATCH for-6.2 05/12] [automated] Move QOM typedefs and add missing includes To: Eduardo Habkost , qemu-devel@nongnu.org References: <20210806211127.646908-1-ehabkost@redhat.com> <20210806211127.646908-6-ehabkost@redhat.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <80f33c09-58d6-e45b-c1de-4050b1a359be@amsat.org> Date: Sat, 7 Aug 2021 10:13:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210806211127.646908-6-ehabkost@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x429.google.com X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-2.619, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Huacai Chen , "Michael S. Tsirkin" , Alexey Kardashevskiy , Jason Wang , Bin Meng , Vijai Kumar K , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Tyrone Ting , Klaus Jensen , "Edgar E. Iglesias" , Vikram Garhwal , qemu-block@nongnu.org, Stefan Berger , David Hildenbrand , Havard Skinnemoen , Halil Pasic , Christian Borntraeger , =?UTF-8?Q?Herv=c3=a9_Poussineau?= , Joel Stanley , =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , Bandan Das , Pavel Pisa , Aleksandar Rikalo , Corey Minyard , Richard Henderson , Greg Kurz , "Dr. David Alan Gilbert" , Alexander Bulekov , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Stefan Hajnoczi , Igor Mammedov , Keith Busch , "Daniel P. Berrange" , Palmer Dabbelt , David Gibson , qemu-riscv@nongnu.org, Francisco Iglesias , Andrew Jeffery , Bastian Koppelmann , Juan Quintela , Laurent Vivier , Andrew Baumann , Thomas Huth , qemu-ppc@nongnu.org, Cornelia Huck , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/6/21 11:11 PM, Eduardo Habkost wrote: > Some typedefs and macros are defined after the type check macros. > This makes it difficult to automatically replace their > definitions with OBJECT_DECLARE_TYPE. > > Patch generated using: > > $ ./scripts/codeconverter/converter.py -i --pattern=MoveSymbols \ > $(git grep -l '' -- '*.[ch]') > > which will: > - split "typdef struct { ... } TypedefName" declarations > - move the typedefs and #defines above the type check macros > - add missing #include "qom/object.h" lines if necessary > > Signed-off-by: Eduardo Habkost > --- > Cc: Richard Henderson > Cc: Paolo Bonzini > Cc: "Marc-André Lureau" > Cc: Peter Maydell > Cc: Andrew Baumann > Cc: "Philippe Mathieu-Daudé" > Cc: Thomas Huth > Cc: "Michael S. Tsirkin" > Cc: Igor Mammedov > Cc: Alexander Bulekov > Cc: Bandan Das > Cc: Stefan Hajnoczi > Cc: Huacai Chen > Cc: Jiaxun Yang > Cc: Aurelien Jarno > Cc: Aleksandar Rikalo > Cc: Havard Skinnemoen > Cc: Tyrone Ting > Cc: Pavel Pisa > Cc: Vikram Garhwal > Cc: Jason Wang > Cc: Keith Busch > Cc: Klaus Jensen > Cc: Cornelia Huck > Cc: Halil Pasic > Cc: Christian Borntraeger > Cc: David Hildenbrand > Cc: Gerd Hoffmann > Cc: Vijai Kumar K > Cc: Alistair Francis > Cc: Bin Meng > Cc: Palmer Dabbelt > Cc: "Edgar E. Iglesias" > Cc: Laurent Vivier > Cc: Corey Minyard > Cc: "Cédric Le Goater" > Cc: Andrew Jeffery > Cc: Joel Stanley > Cc: Francisco Iglesias > Cc: David Gibson > Cc: Greg Kurz > Cc: Alexey Kardashevskiy > Cc: "Hervé Poussineau" > Cc: Bastian Koppelmann > Cc: Juan Quintela > Cc: "Dr. David Alan Gilbert" > Cc: "Daniel P. Berrangé" > Cc: Eduardo Habkost > Cc: Stefan Berger > Cc: Taylor Simpson > Cc: qemu-devel@nongnu.org > Cc: qemu-arm@nongnu.org > Cc: qemu-block@nongnu.org > Cc: qemu-s390x@nongnu.org > Cc: qemu-riscv@nongnu.org > Cc: qemu-ppc@nongnu.org > --- > hw/nvme/nvme.h | 6 ++++-- > hw/usb/hcd-uhci.h | 1 + > hw/usb/hcd-xhci-pci.h | 6 ++++-- > hw/usb/hcd-xhci-sysbus.h | 6 ++++-- > hw/usb/u2f.h | 6 ++++-- > include/hw/acpi/acpi_dev_interface.h | 2 +- > include/hw/adc/npcm7xx_adc.h | 1 + > include/hw/arm/linux-boot-if.h | 2 +- > include/hw/arm/npcm7xx.h | 11 +++++++---- > include/hw/char/shakti_uart.h | 6 ++++-- > include/hw/core/accel-cpu.h | 1 + > include/hw/dma/sifive_pdma.h | 1 + > include/hw/dma/xlnx_csu_dma.h | 1 + > include/hw/fw-path-provider.h | 2 +- > include/hw/gpio/npcm7xx_gpio.h | 1 + > include/hw/hotplug.h | 2 +- > include/hw/i2c/npcm7xx_smbus.h | 1 + > include/hw/intc/intc.h | 2 +- > include/hw/intc/m68k_irqc.h | 6 ++++-- > include/hw/intc/sifive_clint.h | 6 ++++-- > include/hw/ipmi/ipmi.h | 2 +- > include/hw/mem/memory-device.h | 2 +- > include/hw/mem/npcm7xx_mc.h | 1 + > include/hw/misc/aspeed_lpc.h | 6 ++++-- > include/hw/misc/bcm2835_cprman.h | 1 + > include/hw/misc/bcm2835_cprman_internals.h | 1 + > include/hw/misc/mchp_pfsoc_dmc.h | 1 + > include/hw/misc/mchp_pfsoc_ioscb.h | 1 + > include/hw/misc/mchp_pfsoc_sysreg.h | 1 + > include/hw/misc/npcm7xx_clk.h | 1 + > include/hw/misc/npcm7xx_gcr.h | 1 + > include/hw/misc/npcm7xx_pwm.h | 1 + > include/hw/misc/npcm7xx_rng.h | 1 + > include/hw/misc/xlnx-versal-xramc.h | 6 ++++-- > include/hw/net/npcm7xx_emc.h | 1 + > include/hw/net/xlnx-zynqmp-can.h | 6 ++++-- > include/hw/nmi.h | 2 +- > include/hw/nvram/npcm7xx_otp.h | 1 + > include/hw/ppc/spapr_drc.h | 15 +++++++++------ > include/hw/ppc/spapr_xive.h | 11 +++++++---- > include/hw/ppc/vof.h | 1 + > include/hw/rdma/rdma.h | 2 +- > include/hw/riscv/microchip_pfsoc.h | 1 + > include/hw/riscv/shakti_c.h | 11 +++++++---- > include/hw/riscv/sifive_e.h | 6 ++++-- > include/hw/riscv/sifive_u.h | 11 +++++++---- > include/hw/rtc/m48t59.h | 2 +- > include/hw/sd/cadence_sdhci.h | 1 + > include/hw/ssi/npcm7xx_fiu.h | 1 + > include/hw/ssi/sifive_spi.h | 6 ++++-- > include/hw/stream.h | 2 +- > include/hw/timer/npcm7xx_timer.h | 1 + > include/hw/tricore/tricore_testdevice.h | 6 ++++-- > include/hw/usb/hcd-dwc3.h | 6 ++++-- > include/hw/usb/msd.h | 1 + > include/hw/usb/xlnx-usb-subsystem.h | 6 ++++-- > include/hw/usb/xlnx-versal-usb2-ctrl-regs.h | 6 ++++-- > include/hw/vmstate-if.h | 2 +- > include/hw/watchdog/sbsa_gwdt.h | 6 ++++-- > include/qom/object_interfaces.h | 2 +- > include/sysemu/tpm.h | 2 +- > target/arm/idau.h | 2 +- > target/hexagon/cpu.h | 11 +++++++---- > accel/tcg/tcg-all.c | 1 + > chardev/char-parallel.c | 1 + > hw/arm/bcm2836.c | 1 + > hw/m68k/mcf5206.c | 1 + > hw/mem/sparse-mem.c | 6 ++++-- > hw/mips/loongson3_virt.c | 1 + > hw/misc/npcm7xx_clk.c | 1 + > hw/misc/sbsa_ec.c | 1 + > hw/net/can/ctucan_pci.c | 1 + > hw/nvram/npcm7xx_otp.c | 1 + > hw/s390x/vhost-user-fs-ccw.c | 1 + > hw/sensor/adm1272.c | 6 ++++-- > hw/sensor/max34451.c | 6 ++++-- > hw/usb/u2f-emulated.c | 1 + > hw/usb/u2f-passthru.c | 1 + > hw/virtio/vhost-user-i2c-pci.c | 1 + > tests/unit/check-qom-interface.c | 2 +- > ui/vdagent.c | 1 + > 81 files changed, 179 insertions(+), 82 deletions(-) Reviewed-by: Philippe Mathieu-Daudé