From: "Ryan Riley" <rileyrd@gmail.com>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] CPUTLBEntry Question
Date: Thu, 14 Jun 2007 15:31:20 -0400 [thread overview]
Message-ID: <812074ac0706141231w3e132296s98974e9527a3cdfd@mail.gmail.com> (raw)
In-Reply-To: <200706141422.13852.paul@codesourcery.com>
On 6/14/07, Paul Brook <paul@codesourcery.com> wrote:
> > then QEMU crashes on startup. (It also crashes if I put that blah
> > entry on the beginning instead of the end.) I'm sure there's code
> > somewhere that must be making assumptions about the size of TLB entry,
> > but I'm at a loss for finding it. (I have noticed that the assembly
> > code in softmmu_header.h indexes to the addend based on addr_read or
> > addr_write, but adding a new member to the end of the structure
> > shouldn't impact that, right?)
>
> Wrong. The assembly implementation assumes CPUTLBEntry is 16 bytes (or to be
> exact 1 << CPU_TLB_ENTRY_BITS).
>
> The C implementation in softmmu_header.h will work with any layout.
>
> Paul
>
That fixed/answered everything for me. Thanks for your help, everyone.
Thanks
Ryan
next prev parent reply other threads:[~2007-06-14 19:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-13 20:25 [Qemu-devel] CPUTLBEntry Question Ryan Riley
2007-06-14 13:22 ` Paul Brook
2007-06-14 19:31 ` Ryan Riley [this message]
2007-06-14 13:41 ` amateur
2007-06-14 14:00 ` Blue Swirl
2007-06-15 1:47 ` amateur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=812074ac0706141231w3e132296s98974e9527a3cdfd@mail.gmail.com \
--to=rileyrd@gmail.com \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).