From: Max Reitz <mreitz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Test commit job start with concurrent I/O
Date: Wed, 22 May 2019 13:48:31 +0200 [thread overview]
Message-ID: <812adda0-e166-c131-78ad-633e6e468324@redhat.com> (raw)
In-Reply-To: <20190521191638.32713-3-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 853 bytes --]
On 21.05.19 21:16, Kevin Wolf wrote:
> This tests that concurrent requests are correctly drained before making
> graph modifications instead of running into assertions in
> bdrv_replace_node().
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> tests/qemu-iotests/255 | 83 +++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/255.out | 16 +++++++
> tests/qemu-iotests/group | 1 +
> tests/qemu-iotests/iotests.py | 10 ++++-
> 4 files changed, 109 insertions(+), 1 deletion(-)
> create mode 100755 tests/qemu-iotests/255
> create mode 100644 tests/qemu-iotests/255.out
Reviewed-by: Max Reitz <mreitz@redhat.com>
(By the way, because I see throttle on mirror, here, too: My problem
involves a concurrent bdrv_drain_all(), that’s the slight difference.
But your patch 1 works well for me.)
(Max)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-05-22 11:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-21 19:16 [Qemu-devel] [PATCH 0/2] commit: Fix crash on job start with active I/O Kevin Wolf
2019-05-21 19:16 ` [Qemu-devel] [PATCH 1/2] block: Drain source node in bdrv_replace_node() Kevin Wolf
2019-05-22 11:28 ` Max Reitz
2019-05-21 19:16 ` [Qemu-devel] [PATCH 2/2] iotests: Test commit job start with concurrent I/O Kevin Wolf
2019-05-22 11:48 ` Max Reitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=812adda0-e166-c131-78ad-633e6e468324@redhat.com \
--to=mreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).