From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, berrange@redhat.com,
alex.bennee@linaro.org, jsnow@redhat.com,
kconsul@linux.vnet.ibm.com
Subject: Re: [PATCH 0/2] Fix venv issues with Avocado by reverting to an older version
Date: Mon, 5 Jun 2023 12:51:40 +0200 [thread overview]
Message-ID: <814834c9-b257-8cdb-7372-35e689bc37ac@redhat.com> (raw)
In-Reply-To: <CAFEAcA8fRWdFMrcy6G6yT-8320UZUf6QA9XO70f7P1ssraedRQ@mail.gmail.com>
On 6/5/23 11:46, Peter Maydell wrote:
>> To avoid this issue, tests/requirements.txt should use a ">=" constraint
>> and the version of Avocado should be limited to what distros provide
>> in the system packages. Only Fedora has Avocado, and more specifically
>> version 92.0. For now, this series reverts to the older requirement
>> (version >=88.1) while leaving further version bumps to future changes.
> If the new Avocado version is broken, don't we also need a < constraint
> so we don't get it by mistake ?
I expected those to be bugs that get fixed in 102 or 101.1, so not a
reason to impose a strict constraint. But you're right, the version
that would be installed from PyPI is the latest; I didn't notice because
I do have avocado installed outside pyvenv/.
Is the logging issue limited to the one fixed by
https://www.mail-archive.com/qemu-devel@nongnu.org/msg962758.html? Or
is there something more?
> In particular, for a local build tree that currently has 101 installed,
> if the tree is updated to include these two patches together, will that
> correctly downgrade it to 88.1?
No, it won't. What you can do is "pyvenv/bin/pip uninstall
avocado-framework".
Paolo
next prev parent reply other threads:[~2023-06-05 10:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-05 7:58 [PATCH 0/2] Fix venv issues with Avocado by reverting to an older version Paolo Bonzini
2023-06-05 7:58 ` [PATCH 1/2] Revert "tests/requirements.txt: bump up avocado-framework version to 101.0" Paolo Bonzini
2023-06-05 7:58 ` [PATCH 2/2] tests: update avocado installation to use mkvenv Paolo Bonzini
2023-06-05 9:46 ` [PATCH 0/2] Fix venv issues with Avocado by reverting to an older version Peter Maydell
2023-06-05 10:51 ` Paolo Bonzini [this message]
2023-06-05 10:58 ` Peter Maydell
2023-06-05 15:29 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=814834c9-b257-8cdb-7372-35e689bc37ac@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=jsnow@redhat.com \
--cc=kconsul@linux.vnet.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).