* [PATCH 0/2] Fix probe_pages and vext_ldff issues
@ 2026-03-18 1:38 Max Chou
2026-03-18 1:38 ` [PATCH 1/2] target/riscv: rvv: Fix missing flags merge in probe_pages for cross-page accesses Max Chou
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Max Chou @ 2026-03-18 1:38 UTC (permalink / raw)
To: qemu-devel, qemu-riscv
Cc: Palmer Dabbelt, Alistair Francis, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, Chao Liu, Max Chou
This patchset fixes following issues in the RISC-V vector
fault-only-first load implementation and the probe_pages helper
function.
1. probe_pages flag handling:
When probing memory spanning two pages, probe_pages calls
probe_access_flags twice. The flags from the second page were
overwriting the first page's flags instead of being merged, causing
watchpoint and other TLB attributes to be lost.
2. vext_ldff cross-page logic:
The manual two-phase probing in vext_ldff had three issues:
a) Wrong condition: checked "env->vl > elems" instead of
"env->vl > elems + env->vstart", missing the vstart offset
b) Wrong address: used "addr + (elems << log2_esz)" instead of
"addr + page_split", probing incorrect addresses for segment
loads (nf > 1)
c) Wrong size: used "elems * msize" (first page size) instead of
calculating remaining size, potentially missing faults
Patch 1 fixes the probe_pages helper to properly merge flags from both
pages.
Patch 2 fixes vext_ldff by replacing the buggy manual cross-page logic
by a single probe_pages call with the correct total size. This
leverages the infrastructure that probe_pages already provides for
handling cross-page accesses automatically.
rnax
Max Chou (2):
target/riscv: rvv: Fix missing flags merge in probe_pages for
cross-page accesses
target/riscv: rvv: Fix page probe issues in vext_ldff
target/riscv/vector_helper.c | 23 +++++++----------------
1 file changed, 7 insertions(+), 16 deletions(-)
--
2.43.7
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH 1/2] target/riscv: rvv: Fix missing flags merge in probe_pages for cross-page accesses
2026-03-18 1:38 [PATCH 0/2] Fix probe_pages and vext_ldff issues Max Chou
@ 2026-03-18 1:38 ` Max Chou
2026-03-19 3:23 ` Alistair Francis
2026-03-18 1:38 ` [PATCH 2/2] target/riscv: rvv: Fix page probe issues in vext_ldff Max Chou
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Max Chou @ 2026-03-18 1:38 UTC (permalink / raw)
To: qemu-devel, qemu-riscv
Cc: Palmer Dabbelt, Alistair Francis, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, Chao Liu, Max Chou
When probe_pages probes a memory region that spans two pages, it calls
probe_access_flags twice - once for each page. However, the flags from
the second page probe were overwriting the flags from the first page
instead of being merged together.
Signed-off-by: Max Chou <max.chou@sifive.com>
---
target/riscv/vector_helper.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index 3334662dcd..a74ce70943 100644
--- a/target/riscv/vector_helper.c
+++ b/target/riscv/vector_helper.c
@@ -265,9 +265,9 @@ static void probe_pages(CPURISCVState *env, target_ulong addr, target_ulong len,
addr += curlen;
curlen = len - curlen;
if (flags != NULL) {
- *flags = probe_access_flags(env, adjust_addr(env, addr), curlen,
- access_type, mmu_index, nonfault,
- host, ra);
+ *flags |= probe_access_flags(env, adjust_addr(env, addr), curlen,
+ access_type, mmu_index, nonfault,
+ host, ra);
} else {
probe_access(env, adjust_addr(env, addr), curlen, access_type,
mmu_index, ra);
@@ -275,7 +275,6 @@ static void probe_pages(CPURISCVState *env, target_ulong addr, target_ulong len,
}
}
-
static inline void vext_set_elem_mask(void *v0, int index,
uint8_t value)
{
--
2.43.7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 2/2] target/riscv: rvv: Fix page probe issues in vext_ldff
2026-03-18 1:38 [PATCH 0/2] Fix probe_pages and vext_ldff issues Max Chou
2026-03-18 1:38 ` [PATCH 1/2] target/riscv: rvv: Fix missing flags merge in probe_pages for cross-page accesses Max Chou
@ 2026-03-18 1:38 ` Max Chou
2026-03-19 3:25 ` Alistair Francis
2026-03-19 3:30 ` [PATCH 0/2] Fix probe_pages and vext_ldff issues Alistair Francis
2026-03-20 20:53 ` Michael Tokarev
3 siblings, 1 reply; 11+ messages in thread
From: Max Chou @ 2026-03-18 1:38 UTC (permalink / raw)
To: qemu-devel, qemu-riscv
Cc: Palmer Dabbelt, Alistair Francis, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, Chao Liu, Max Chou
Commit 17288e38bebf ("optimize the memory probing for vector
fault-only-first loads") introduced an optimization that moved from
per-element probing to a fast-path broad probe. Unfortunately it
introduced following bugs in cross-page handling:
- Wrong condition for second page probing: checked "env->vl > elems"
instead of "env->vl > elems + env->vstart", failing to account for
the vstart offset.
- Incorrect second page address calculation: used
"addr + (elems << log2_esz)" instead of "addr + page_split".
For segment loads (nf > 1), this would probe the wrong address,not
at the page boundary.
- Wrong second page probe size: used "elems * msize" (the first page
size) instead of calculating the remaining size as
"(env->vl - env->vstart) * msize - page_split". This would probe
too little memory and could miss faults.
This commit fixes these bugs by leveraging the probe_pages helper
which automatically handles cross-page memory accesses correctly.
Fixes: 17288e38bebf ("optimize the memory probing for vector fault-only-first loads.")
Signed-off-by: Max Chou <max.chou@sifive.com>
---
target/riscv/vector_helper.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
index a74ce70943..f038997095 100644
--- a/target/riscv/vector_helper.c
+++ b/target/riscv/vector_helper.c
@@ -772,9 +772,9 @@ vext_ldff(void *vd, void *v0, target_ulong base, CPURISCVState *env,
uint32_t esz = 1 << log2_esz;
uint32_t msize = nf * esz;
uint32_t vma = vext_vma(desc);
- target_ulong addr, addr_probe, addr_i, offset, remain, page_split, elems;
+ target_ulong addr, addr_i, offset, remain, page_split, elems;
int mmu_index = riscv_env_mmu_index(env, false);
- int flags, probe_flags;
+ int flags;
void *host;
VSTART_CHECK_EARLY_EXIT(env, env->vl);
@@ -788,16 +788,8 @@ vext_ldff(void *vd, void *v0, target_ulong base, CPURISCVState *env,
}
/* Check page permission/pmp/watchpoint/etc. */
- probe_pages(env, addr, elems * msize, ra, MMU_DATA_LOAD, mmu_index, &host,
- &flags, true);
-
- /* If we are crossing a page check also the second page. */
- if (env->vl > elems) {
- addr_probe = addr + (elems << log2_esz);
- probe_pages(env, addr_probe, elems * msize, ra, MMU_DATA_LOAD,
- mmu_index, &host, &probe_flags, true);
- flags |= probe_flags;
- }
+ probe_pages(env, addr, (env->vl - env->vstart) * msize, ra, MMU_DATA_LOAD,
+ mmu_index, &host, &flags, true);
if (flags & ~TLB_WATCHPOINT) {
/* probe every access */
--
2.43.7
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH 1/2] target/riscv: rvv: Fix missing flags merge in probe_pages for cross-page accesses
2026-03-18 1:38 ` [PATCH 1/2] target/riscv: rvv: Fix missing flags merge in probe_pages for cross-page accesses Max Chou
@ 2026-03-19 3:23 ` Alistair Francis
0 siblings, 0 replies; 11+ messages in thread
From: Alistair Francis @ 2026-03-19 3:23 UTC (permalink / raw)
To: Max Chou
Cc: qemu-devel, qemu-riscv, Palmer Dabbelt, Alistair Francis,
Weiwei Li, Daniel Henrique Barboza, Liu Zhiwei, Chao Liu
On Wed, Mar 18, 2026 at 11:38 AM Max Chou <max.chou@sifive.com> wrote:
>
> When probe_pages probes a memory region that spans two pages, it calls
> probe_access_flags twice - once for each page. However, the flags from
> the second page probe were overwriting the flags from the first page
> instead of being merged together.
>
> Signed-off-by: Max Chou <max.chou@sifive.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/vector_helper.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
> index 3334662dcd..a74ce70943 100644
> --- a/target/riscv/vector_helper.c
> +++ b/target/riscv/vector_helper.c
> @@ -265,9 +265,9 @@ static void probe_pages(CPURISCVState *env, target_ulong addr, target_ulong len,
> addr += curlen;
> curlen = len - curlen;
> if (flags != NULL) {
> - *flags = probe_access_flags(env, adjust_addr(env, addr), curlen,
> - access_type, mmu_index, nonfault,
> - host, ra);
> + *flags |= probe_access_flags(env, adjust_addr(env, addr), curlen,
> + access_type, mmu_index, nonfault,
> + host, ra);
> } else {
> probe_access(env, adjust_addr(env, addr), curlen, access_type,
> mmu_index, ra);
> @@ -275,7 +275,6 @@ static void probe_pages(CPURISCVState *env, target_ulong addr, target_ulong len,
> }
> }
>
> -
> static inline void vext_set_elem_mask(void *v0, int index,
> uint8_t value)
> {
> --
> 2.43.7
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 2/2] target/riscv: rvv: Fix page probe issues in vext_ldff
2026-03-18 1:38 ` [PATCH 2/2] target/riscv: rvv: Fix page probe issues in vext_ldff Max Chou
@ 2026-03-19 3:25 ` Alistair Francis
0 siblings, 0 replies; 11+ messages in thread
From: Alistair Francis @ 2026-03-19 3:25 UTC (permalink / raw)
To: Max Chou
Cc: qemu-devel, qemu-riscv, Palmer Dabbelt, Alistair Francis,
Weiwei Li, Daniel Henrique Barboza, Liu Zhiwei, Chao Liu
On Wed, Mar 18, 2026 at 11:38 AM Max Chou <max.chou@sifive.com> wrote:
>
> Commit 17288e38bebf ("optimize the memory probing for vector
> fault-only-first loads") introduced an optimization that moved from
> per-element probing to a fast-path broad probe. Unfortunately it
> introduced following bugs in cross-page handling:
>
> - Wrong condition for second page probing: checked "env->vl > elems"
> instead of "env->vl > elems + env->vstart", failing to account for
> the vstart offset.
>
> - Incorrect second page address calculation: used
> "addr + (elems << log2_esz)" instead of "addr + page_split".
> For segment loads (nf > 1), this would probe the wrong address,not
> at the page boundary.
>
> - Wrong second page probe size: used "elems * msize" (the first page
> size) instead of calculating the remaining size as
> "(env->vl - env->vstart) * msize - page_split". This would probe
> too little memory and could miss faults.
>
> This commit fixes these bugs by leveraging the probe_pages helper
> which automatically handles cross-page memory accesses correctly.
>
> Fixes: 17288e38bebf ("optimize the memory probing for vector fault-only-first loads.")
>
> Signed-off-by: Max Chou <max.chou@sifive.com>
Acked-by: Alistair Francis <alistair.francis@wdc.com>
Alistair
> ---
> target/riscv/vector_helper.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c
> index a74ce70943..f038997095 100644
> --- a/target/riscv/vector_helper.c
> +++ b/target/riscv/vector_helper.c
> @@ -772,9 +772,9 @@ vext_ldff(void *vd, void *v0, target_ulong base, CPURISCVState *env,
> uint32_t esz = 1 << log2_esz;
> uint32_t msize = nf * esz;
> uint32_t vma = vext_vma(desc);
> - target_ulong addr, addr_probe, addr_i, offset, remain, page_split, elems;
> + target_ulong addr, addr_i, offset, remain, page_split, elems;
> int mmu_index = riscv_env_mmu_index(env, false);
> - int flags, probe_flags;
> + int flags;
> void *host;
>
> VSTART_CHECK_EARLY_EXIT(env, env->vl);
> @@ -788,16 +788,8 @@ vext_ldff(void *vd, void *v0, target_ulong base, CPURISCVState *env,
> }
>
> /* Check page permission/pmp/watchpoint/etc. */
> - probe_pages(env, addr, elems * msize, ra, MMU_DATA_LOAD, mmu_index, &host,
> - &flags, true);
> -
> - /* If we are crossing a page check also the second page. */
> - if (env->vl > elems) {
> - addr_probe = addr + (elems << log2_esz);
> - probe_pages(env, addr_probe, elems * msize, ra, MMU_DATA_LOAD,
> - mmu_index, &host, &probe_flags, true);
> - flags |= probe_flags;
> - }
> + probe_pages(env, addr, (env->vl - env->vstart) * msize, ra, MMU_DATA_LOAD,
> + mmu_index, &host, &flags, true);
>
> if (flags & ~TLB_WATCHPOINT) {
> /* probe every access */
> --
> 2.43.7
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] Fix probe_pages and vext_ldff issues
2026-03-18 1:38 [PATCH 0/2] Fix probe_pages and vext_ldff issues Max Chou
2026-03-18 1:38 ` [PATCH 1/2] target/riscv: rvv: Fix missing flags merge in probe_pages for cross-page accesses Max Chou
2026-03-18 1:38 ` [PATCH 2/2] target/riscv: rvv: Fix page probe issues in vext_ldff Max Chou
@ 2026-03-19 3:30 ` Alistair Francis
2026-03-20 20:53 ` Michael Tokarev
3 siblings, 0 replies; 11+ messages in thread
From: Alistair Francis @ 2026-03-19 3:30 UTC (permalink / raw)
To: Max Chou
Cc: qemu-devel, qemu-riscv, Palmer Dabbelt, Alistair Francis,
Weiwei Li, Daniel Henrique Barboza, Liu Zhiwei, Chao Liu
On Wed, Mar 18, 2026 at 11:38 AM Max Chou <max.chou@sifive.com> wrote:
>
> This patchset fixes following issues in the RISC-V vector
> fault-only-first load implementation and the probe_pages helper
> function.
>
> 1. probe_pages flag handling:
> When probing memory spanning two pages, probe_pages calls
> probe_access_flags twice. The flags from the second page were
> overwriting the first page's flags instead of being merged, causing
> watchpoint and other TLB attributes to be lost.
>
> 2. vext_ldff cross-page logic:
> The manual two-phase probing in vext_ldff had three issues:
> a) Wrong condition: checked "env->vl > elems" instead of
> "env->vl > elems + env->vstart", missing the vstart offset
> b) Wrong address: used "addr + (elems << log2_esz)" instead of
> "addr + page_split", probing incorrect addresses for segment
> loads (nf > 1)
> c) Wrong size: used "elems * msize" (first page size) instead of
> calculating remaining size, potentially missing faults
>
>
> Patch 1 fixes the probe_pages helper to properly merge flags from both
> pages.
>
> Patch 2 fixes vext_ldff by replacing the buggy manual cross-page logic
> by a single probe_pages call with the correct total size. This
> leverages the infrastructure that probe_pages already provides for
> handling cross-page accesses automatically.
>
> rnax
>
>
> Max Chou (2):
> target/riscv: rvv: Fix missing flags merge in probe_pages for
> cross-page accesses
> target/riscv: rvv: Fix page probe issues in vext_ldff
Thanks!
Applied to riscv-to-apply.next
Alistair
>
> target/riscv/vector_helper.c | 23 +++++++----------------
> 1 file changed, 7 insertions(+), 16 deletions(-)
>
> --
> 2.43.7
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] Fix probe_pages and vext_ldff issues
2026-03-18 1:38 [PATCH 0/2] Fix probe_pages and vext_ldff issues Max Chou
` (2 preceding siblings ...)
2026-03-19 3:30 ` [PATCH 0/2] Fix probe_pages and vext_ldff issues Alistair Francis
@ 2026-03-20 20:53 ` Michael Tokarev
2026-03-23 7:08 ` Max Chou
3 siblings, 1 reply; 11+ messages in thread
From: Michael Tokarev @ 2026-03-20 20:53 UTC (permalink / raw)
To: Max Chou, qemu-devel, qemu-riscv
Cc: Palmer Dabbelt, Alistair Francis, Weiwei Li,
Daniel Henrique Barboza, Liu Zhiwei, Chao Liu, qemu-stable
On 18.03.2026 04:38, Max Chou wrote:
> This patchset fixes following issues in the RISC-V vector
> fault-only-first load implementation and the probe_pages helper
> function.
>
> 1. probe_pages flag handling:
> When probing memory spanning two pages, probe_pages calls
> probe_access_flags twice. The flags from the second page were
> overwriting the first page's flags instead of being merged, causing
> watchpoint and other TLB attributes to be lost.
>
> 2. vext_ldff cross-page logic:
> The manual two-phase probing in vext_ldff had three issues:
> a) Wrong condition: checked "env->vl > elems" instead of
> "env->vl > elems + env->vstart", missing the vstart offset
> b) Wrong address: used "addr + (elems << log2_esz)" instead of
> "addr + page_split", probing incorrect addresses for segment
> loads (nf > 1)
> c) Wrong size: used "elems * msize" (first page size) instead of
> calculating remaining size, potentially missing faults
>
>
> Patch 1 fixes the probe_pages helper to properly merge flags from both
> pages.
>
> Patch 2 fixes vext_ldff by replacing the buggy manual cross-page logic
> by a single probe_pages call with the correct total size. This
> leverages the infrastructure that probe_pages already provides for
> handling cross-page accesses automatically.
>
> rnax
This feels like a qemu-stable material but I'm not sure about that.
Please let me know if these fixes should be picked up for the current
stable releases of qemu, especially for 10.0.x series which is currently
an LTS series.
Thanks,
/mjt
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] Fix probe_pages and vext_ldff issues
2026-03-20 20:53 ` Michael Tokarev
@ 2026-03-23 7:08 ` Max Chou
2026-03-23 7:26 ` Michael Tokarev
0 siblings, 1 reply; 11+ messages in thread
From: Max Chou @ 2026-03-23 7:08 UTC (permalink / raw)
To: Michael Tokarev
Cc: qemu-devel, qemu-riscv, Palmer Dabbelt, Alistair Francis,
Weiwei Li, Daniel Henrique Barboza, Liu Zhiwei, Chao Liu,
qemu-stable
On 2026-03-20 23:53, Michael Tokarev wrote:
> This feels like a qemu-stable material but I'm not sure about that.
>
> Please let me know if these fixes should be picked up for the current
> stable releases of qemu, especially for 10.0.x series which is currently
> an LTS series.
>
> Thanks,
>
> /mjt
Hi Michael,
Yes, I believe this patchset should be picked up for the current stable
release. These patches address the issues that were introduced after
v10.0.0-rc0.
Thanks,
rnax
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] Fix probe_pages and vext_ldff issues
2026-03-23 7:08 ` Max Chou
@ 2026-03-23 7:26 ` Michael Tokarev
2026-03-23 8:19 ` Max Chou
0 siblings, 1 reply; 11+ messages in thread
From: Michael Tokarev @ 2026-03-23 7:26 UTC (permalink / raw)
To: Max Chou
Cc: qemu-devel, qemu-riscv, Palmer Dabbelt, Alistair Francis,
Weiwei Li, Daniel Henrique Barboza, Liu Zhiwei, Chao Liu,
qemu-stable, Paolo Savini
On 23.03.2026 10:08, Max Chou wrote:
> Yes, I believe this patchset should be picked up for the current stable
> release. These patches address the issues that were introduced after
> v10.0.0-rc0.
This makes sense.
However, 10.0 lacks d887736225 "Expand the probe_pages helper function
to handle probe flags", which makes the first change in this series
(5568177738 "target/riscv: rvv: Fix missing flags merge in probe_pages
for cross-page accesses") non-applicable.
Is it okay to pick d887736225 for 10.0.x too? (Adding Paolo Savini to
the Cc list).
The result works and passes tests but since it's not my area it'd be
nice if someone can confirm/deny. Or maybe some other fixes should be
picked up for 10.0.x too. The current result is at
https://gitlab.com/mjt0k/qemu/-/commits/staging-10.0
Thanks!
/mjt
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] Fix probe_pages and vext_ldff issues
2026-03-23 7:26 ` Michael Tokarev
@ 2026-03-23 8:19 ` Max Chou
2026-03-23 10:57 ` Paolo Savini
0 siblings, 1 reply; 11+ messages in thread
From: Max Chou @ 2026-03-23 8:19 UTC (permalink / raw)
To: Michael Tokarev
Cc: qemu-devel, qemu-riscv, Palmer Dabbelt, Alistair Francis,
Weiwei Li, Daniel Henrique Barboza, Liu Zhiwei, Chao Liu,
qemu-stable, Paolo Savini
On 2026-03-23 10:26, Michael Tokarev wrote:
> This makes sense.
>
> However, 10.0 lacks d887736225 "Expand the probe_pages helper function
> to handle probe flags", which makes the first change in this series
> (5568177738 "target/riscv: rvv: Fix missing flags merge in probe_pages
> for cross-page accesses") non-applicable.
>
> Is it okay to pick d887736225 for 10.0.x too? (Adding Paolo Savini to
> the Cc list).
>
> The result works and passes tests but since it's not my area it'd be
> nice if someone can confirm/deny. Or maybe some other fixes should be
> picked up for 10.0.x too. The current result is at
> https://gitlab.com/mjt0k/qemu/-/commits/staging-10.0
>
> Thanks!
>
> /mjt
Hi Michael,
Regarding commit d887736225, I agree with you that it should be picked
up for the 10.0.x series. It includes the necessary modifications for
probe_pages that enable the first patch of this patchset to apply
correctly, so I think that is okay to include.
I've checked the cherry-picks (3b3e6682/2f4335d7/ba624f3f) in the
stable-10.0, and they LGTM. It appears to include the related commits of
this patchset.
Thanks,
rnax
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH 0/2] Fix probe_pages and vext_ldff issues
2026-03-23 8:19 ` Max Chou
@ 2026-03-23 10:57 ` Paolo Savini
0 siblings, 0 replies; 11+ messages in thread
From: Paolo Savini @ 2026-03-23 10:57 UTC (permalink / raw)
To: Max Chou, Michael Tokarev
Cc: qemu-devel, qemu-riscv, Palmer Dabbelt, Alistair Francis,
Weiwei Li, Daniel Henrique Barboza, Liu Zhiwei, Chao Liu,
qemu-stable
[-- Attachment #1: Type: text/plain, Size: 1339 bytes --]
Hi Michael,
Thanks for this. I agree commitd887736225 is needed and adding it looks
legitimate to me.
Best wishes
Paolo Savini
On 3/23/26 08:19, Max Chou wrote:
> On 2026-03-23 10:26, Michael Tokarev wrote:
>> This makes sense.
>>
>> However, 10.0 lacks d887736225 "Expand the probe_pages helper function
>> to handle probe flags", which makes the first change in this series
>> (5568177738 "target/riscv: rvv: Fix missing flags merge in probe_pages
>> for cross-page accesses") non-applicable.
>>
>> Is it okay to pick d887736225 for 10.0.x too? (Adding Paolo Savini to
>> the Cc list).
>>
>> The result works and passes tests but since it's not my area it'd be
>> nice if someone can confirm/deny. Or maybe some other fixes should be
>> picked up for 10.0.x too. The current result is at
>> https://gitlab.com/mjt0k/qemu/-/commits/staging-10.0
>>
>> Thanks!
>>
>> /mjt
> Hi Michael,
>
> Regarding commit d887736225, I agree with you that it should be picked
> up for the 10.0.x series. It includes the necessary modifications for
> probe_pages that enable the first patch of this patchset to apply
> correctly, so I think that is okay to include.
>
> I've checked the cherry-picks (3b3e6682/2f4335d7/ba624f3f) in the
> stable-10.0, and they LGTM. It appears to include the related commits of
> this patchset.
>
> Thanks,
>
> rnax
[-- Attachment #2: Type: text/html, Size: 2085 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-03-23 10:57 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-18 1:38 [PATCH 0/2] Fix probe_pages and vext_ldff issues Max Chou
2026-03-18 1:38 ` [PATCH 1/2] target/riscv: rvv: Fix missing flags merge in probe_pages for cross-page accesses Max Chou
2026-03-19 3:23 ` Alistair Francis
2026-03-18 1:38 ` [PATCH 2/2] target/riscv: rvv: Fix page probe issues in vext_ldff Max Chou
2026-03-19 3:25 ` Alistair Francis
2026-03-19 3:30 ` [PATCH 0/2] Fix probe_pages and vext_ldff issues Alistair Francis
2026-03-20 20:53 ` Michael Tokarev
2026-03-23 7:08 ` Max Chou
2026-03-23 7:26 ` Michael Tokarev
2026-03-23 8:19 ` Max Chou
2026-03-23 10:57 ` Paolo Savini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox