From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:35842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLXwk-00038m-Gf for qemu-devel@nongnu.org; Tue, 30 Apr 2019 14:57:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLXu9-0001EK-5D for qemu-devel@nongnu.org; Tue, 30 Apr 2019 14:55:02 -0400 References: <1552300145-12526-1-git-send-email-thuth@redhat.com> <6d46de0f-a443-2c90-334b-edd34325ac16@redhat.com> From: Thomas Huth Message-ID: <817b41fa-063e-7008-af0a-6758112bca67@redhat.com> Date: Tue, 30 Apr 2019 20:54:51 +0200 MIME-Version: 1.0 In-Reply-To: <6d46de0f-a443-2c90-334b-edd34325ac16@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] configure: Remove old *-config-devices.mak.d files when running configure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= On 11/03/2019 17.21, Eric Blake wrote: > On 3/11/19 5:29 AM, Thomas Huth wrote: >> When running "make" in a build directory from the pre-Kconfig merge ti= me, >> the build process currently fails with: >> >> make: *** No rule to make target `.../default-configs/pci.mak', >> needed by `aarch64-softmmu/config-devices.mak'. Stop. >> >> To make sure that this problem at least goes away when the user runs >> "configure" (or "sh config.status") again, we have to make sure that >> we re-generate the .mak.d files. Thus remove the old stale files >> while running the configure script. >> >> Signed-off-by: Thomas Huth >> --- >> configure | 3 +++ >> 1 file changed, 3 insertions(+) >=20 > What are the conditions for make deciding it needs to rerun > config.status? Are end users still going to get 'make' failing with the > cryptic message (where we just advise on-list and on-wiki to > './config.status' to fix it), or is there a way to build in a dependenc= y > so that the makefile itself knows that if config.status has to be rerun= , > that takes priority over any other rule that depends on .mak files? I just noticed that I never replied to this mail so far, sorry! The conditions for rerunning config.status can be found in the Makefile: config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios $(SRC_PATH)/VE= RSION @echo $@ is out-of-date, running configure ... At least we change VERSION regularly, so while not being perfect, the pro= blem should go away after a while with this patch. Not sure whether there is a= better way to do this - maybe depend on the files in default-configs/, too? Or m= aybe we could simply bump VERSION from x.y.50 to x.y.51 the next time when we eve= r hit such a problem again...? Thomas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 435D9C43219 for ; Tue, 30 Apr 2019 18:59:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06CC920854 for ; Tue, 30 Apr 2019 18:59:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06CC920854 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([127.0.0.1]:51816 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLXyJ-00046S-3M for qemu-devel@archiver.kernel.org; Tue, 30 Apr 2019 14:59:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hLXwk-00038m-Gf for qemu-devel@nongnu.org; Tue, 30 Apr 2019 14:57:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hLXu9-0001EK-5D for qemu-devel@nongnu.org; Tue, 30 Apr 2019 14:55:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45550) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hLXu8-0001Dl-TI; Tue, 30 Apr 2019 14:55:01 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 16088883A2; Tue, 30 Apr 2019 18:54:59 +0000 (UTC) Received: from thuth.remote.csb (ovpn-116-21.ams2.redhat.com [10.36.116.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id BF12F7DF40; Tue, 30 Apr 2019 18:54:52 +0000 (UTC) To: Eric Blake , Paolo Bonzini , qemu-devel@nongnu.org References: <1552300145-12526-1-git-send-email-thuth@redhat.com> <6d46de0f-a443-2c90-334b-edd34325ac16@redhat.com> From: Thomas Huth Openpgp: preference=signencrypt Autocrypt: addr=thuth@redhat.com; keydata= xsFNBFH7eUwBEACzyOXKU+5Pcs6wNpKzrlJwzRl3VGZt95VCdb+FgoU9g11m7FWcOafrVRwU yYkTm9+7zBUc0sW5AuPGR/dp3pSLX/yFWsA/UB4nJsHqgDvDU7BImSeiTrnpMOTXb7Arw2a2 4CflIyFqjCpfDM4MuTmzTjXq4Uov1giGE9X6viNo1pxyEpd7PanlKNnf4PqEQp06X4IgUacW tSGj6Gcns1bCuHV8OPWLkf4hkRnu8hdL6i60Yxz4E6TqlrpxsfYwLXgEeswPHOA6Mn4Cso9O 0lewVYfFfsmokfAVMKWzOl1Sr0KGI5T9CpmRfAiSHpthhHWnECcJFwl72NTi6kUcUzG4se81 O6n9d/kTj7pzTmBdfwuOZ0YUSqcqs0W+l1NcASSYZQaDoD3/SLk+nqVeCBB4OnYOGhgmIHNW 0CwMRO/GK+20alxzk//V9GmIM2ACElbfF8+Uug3pqiHkVnKqM7W9/S1NH2qmxB6zMiJUHlTH gnVeZX0dgH27mzstcF786uPcdEqS0KJuxh2kk5IvUSL3Qn3ZgmgdxBMyCPciD/1cb7/Ahazr 3ThHQXSHXkH/aDXdfLsKVuwDzHLVSkdSnZdt5HHh75/NFHxwaTlydgfHmFFwodK8y/TjyiGZ zg2Kje38xnz8zKn9iesFBCcONXS7txENTzX0z80WKBhK+XSFJwARAQABzRxUaG9tYXMgSHV0 aCA8dGguaHV0aEBnbXguZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIX gAUCUfuWKwIZAQAKCRAu2dd0/nAttbe/EACb9hafyOb2FmhUqeAiBORSsUifFacQ7laVjcgR I4um8CSHvxijYftpkM2EdAtmXIKgbNDpQoXcWLXB9lu9mLgTO4DVT00TRR65ikn3FCWcyT74 ENTOzRKyKLsDCjhXKPblTPIQbYAUCOWElcyAPm0ERd62fA/rKNxgIiNo/l4UODOMoOJm2/Ox ZoTckW68Eqv7k9L7m7j+Hn3hoDTjAmcCBJt+j7pOhzWvCbqoNOIH8C8qvPaNlrba+R/K6jkO 6jZkTbYQpGIofEQJ/TNn38IsNGpI1ALTHWFtoMxp3j2Imz0REO6dRE2fHRN8sVlHgkoeGhmY NbDsDE1jFQOEObFnu0euk//7BXU7tGOHckVAZ8T1smiRPHfQU7UEH2a/grndxJ+PNeM5w7n2 l+FN3cf2KgPotCK2s9MjSdZA7C5e3rFYO8lqiqTJKvc62vqp3e7B0Kjyy5/QtzSOejBij2QL xkKSFNtxIz4MtuxN8e3IDQNxsKry3nF7R4MDvouXlMo6wP9KuyNWb+vFJt9GtbgfDMIFVamp ZfhEWzWRJH4VgksENA4K/BzjEHCcbTUb1TFsiB1VRnBPJ0SqlvifnfKk6HcpkDk6Pg8Q5FOJ gbNHrdgXsm+m/9GF2zUUr+rOlhVbK23TUqKqPfwnD7uxjpakVcJnsVCFqJpZi1F/ga9IN87B TQRR+3lMARAAtp831HniPHb9AuKq3wj83ujZK8lH5RLrfVsB4X1wi47bwo56BqhXpR/zxPTR eOFT0gnbw9UkphVc7uk/alnXMDEmgvnuxv89PwIQX6k3qLABeV7ykJQG/WT5HQ6+2DdGtVw3 2vjYAPiWQeETsgWRRQMDR0/hwp8s8tL/UodwYCScH6Vxx9pdy353L1fK4Bb9G73a+9FPjp9l x+WwKTsltVqSBuSjyZQ3c3EE8qbTidXZxB38JwARH8yN3TX+t65cbBqLl/zRUUUTapHQpUEd yoAsHIml32e4q+3xdLtTdlLi7FgPBItSazcqZPjEcYW73UAuLcmQmfJlQ5PkDiuqcitn+KzH /1pqsTU7QFZjbmSMJyXY0TDErOFuMOjf20b6arcpEqse1V3IKrb+nqqA2azboRm3pEANLAJw iVTwK3qwGRgK5ut6N/Znv20VEHkFUsRAZoOusrIRfR5HFDxlXguAdEz8M/hxXFYYXqOoaCYy 6pJxTjy0Y/tIfmS/g9Bnp8qg9wsrsnk0+XRnDVPak++G3Uq9tJPwpJbyO0vcqEI3vAXkAB7X VXLzvFwi66RrsPUoDkuzj+aCNumtOePDOCpXQGPpKl+l1aYRMN/+lNSk3+1sVuc2C07WnYyE gV/cbEVklPmKrNwu6DeUyD0qI/bVzKMWZAiB1r56hsGeyYcAEQEAAcLBXwQYAQIACQUCUft5 TAIbDAAKCRAu2dd0/nAttYTwEACLAS/THRqXRKb17PQmKwZHerUvZm2klo+lwQ3wNQBHUJAT p2R9ULexyXrJPqjUpy7+voz+FcKiuQBTKyieiIxO46oMxsbXGZ70o3gxjxdYdgimUD6U8PPd JH8tfAL4BR5FZNjspcnscN2jgbF4OrpDeOLyBaj6HPmElNPtECHWCaf1xbIFsZxSDGMA6cUh 0uX3Q8VI7JN1AR2cfiIRY7NrIlWYucJxyKjO3ivWm69nCtsHiJ0wcF8KlVo7F2eLaufo0K8A ynL8SHMF3VEyxsXOP2f1UR9T2Ur30MXcTBpjUxml1TX3RWY5uH89Js/jlIugBwuAmacJ7JYh lTg6sF/GNc4nPb4kk2yktNWTade+TzsllYlJPaorD2Qe8qX0iFUhFC6y9+O6mP4ZvWoYapp9 ezYNuebMgEr93ob1+4sFg3812wNP01WqsGtWCJHnPv/JoonFdMzD/bIkXGEJMk6ks2kxQQZq g6Ik/s/vxOfao/xCn8nHt7GwvVy41795hzK6tbSl+BuyCRp0vfPRP34OnK7+jR2nvQpJu/pU rCELuGwT9hsYkUPjVd4lfylN3mzEc6iAv/wwjsc0DRTSQCpXT3v2ymTAsRKrVaEZLibTXaf+ WslxWek3xNYRiqwwWAJuL652eAlxUgQ5ZS+fXBRTiQpJ+F26I/2lccScRd9G5w== Organization: Red Hat Message-ID: <817b41fa-063e-7008-af0a-6758112bca67@redhat.com> Date: Tue, 30 Apr 2019 20:54:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <6d46de0f-a443-2c90-334b-edd34325ac16@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 30 Apr 2019 18:54:59 +0000 (UTC) Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH] configure: Remove old *-config-devices.mak.d files when running configure X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Message-ID: <20190430185451.X3RKnvwC0d2RIAWLa2aRHnUu2Iq3OkiM-cz9w3fhj2k@z> On 11/03/2019 17.21, Eric Blake wrote: > On 3/11/19 5:29 AM, Thomas Huth wrote: >> When running "make" in a build directory from the pre-Kconfig merge ti= me, >> the build process currently fails with: >> >> make: *** No rule to make target `.../default-configs/pci.mak', >> needed by `aarch64-softmmu/config-devices.mak'. Stop. >> >> To make sure that this problem at least goes away when the user runs >> "configure" (or "sh config.status") again, we have to make sure that >> we re-generate the .mak.d files. Thus remove the old stale files >> while running the configure script. >> >> Signed-off-by: Thomas Huth >> --- >> configure | 3 +++ >> 1 file changed, 3 insertions(+) >=20 > What are the conditions for make deciding it needs to rerun > config.status? Are end users still going to get 'make' failing with the > cryptic message (where we just advise on-list and on-wiki to > './config.status' to fix it), or is there a way to build in a dependenc= y > so that the makefile itself knows that if config.status has to be rerun= , > that takes priority over any other rule that depends on .mak files? I just noticed that I never replied to this mail so far, sorry! The conditions for rerunning config.status can be found in the Makefile: config-host.mak: $(SRC_PATH)/configure $(SRC_PATH)/pc-bios $(SRC_PATH)/VE= RSION @echo $@ is out-of-date, running configure ... At least we change VERSION regularly, so while not being perfect, the pro= blem should go away after a while with this patch. Not sure whether there is a= better way to do this - maybe depend on the files in default-configs/, too? Or m= aybe we could simply bump VERSION from x.y.50 to x.y.51 the next time when we eve= r hit such a problem again...? Thomas