From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76650C433ED for ; Wed, 31 Mar 2021 15:08:30 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DBFBA60FD7 for ; Wed, 31 Mar 2021 15:08:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DBFBA60FD7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:48592 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRcSL-0006bD-2W for qemu-devel@archiver.kernel.org; Wed, 31 Mar 2021 11:08:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRcQP-0005Is-7M for qemu-devel@nongnu.org; Wed, 31 Mar 2021 11:06:30 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30278) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRcQM-0003Pt-3X for qemu-devel@nongnu.org; Wed, 31 Mar 2021 11:06:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617203182; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+7gkFIi1N91FLCYUWSZN++c5zJzTjszVD3mr3Eri16g=; b=H6tQeSHtZLAG4ruBWb+NQQTRWuJWdhMFCwDRSKBIPaF0miBqPXjRxEiQqtf3SLJBjIB4mu lqxylmHeGP0sLOoo9oWGlGun5izr8x5EXBscab+WzEYz46hsF5IQeR0NEqb+8yRSn0ei1a 5R044mOpYnHYGB7H+Xuj+v9o2n4PCEI= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-J_PqMhsYNAOE5bHVQog7mw-1; Wed, 31 Mar 2021 11:06:20 -0400 X-MC-Unique: J_PqMhsYNAOE5bHVQog7mw-1 Received: by mail-wm1-f70.google.com with SMTP id a17so647597wme.4 for ; Wed, 31 Mar 2021 08:06:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+7gkFIi1N91FLCYUWSZN++c5zJzTjszVD3mr3Eri16g=; b=Xo9ofhs8HMrENJQHx7hSd3UykGCpdGgINnKichl9YP1DSyemXOFcdqYizL/UkBBsxz BgU3YC9PrRy4og19bXGQx8tWBW4KW0UUTQLDaPTK8hL1LEercuJwv711aFmXq/c+mHnH 8tDFH78Bhd/dd5P2EY1QpK0pY4Q/LuAuo/1RXTuqQs8r6Nz+vFf0tCl18CSXCODl1xpS ByVGNZoO92n+Z36SWybgEGkW2HgUW8h3a5voFjzXIdAr5+CeFavxMPFCZPHAPRLwaV1m HN+cSzJVTwkAJN1rD2LKODVnzd5g9ZbcwXpfBaHPzSgjYGjxqkzqmtFD8qd8+gZXY/+p B9iw== X-Gm-Message-State: AOAM531LGg9jPUtRxluoflAIXKlkSd5AIB7BABB3H2qkaKTKZMAktMFe jHBsHd5h4eK7L8Flojbd04jsBmRWGtw55xmwXMUiuTFchBrHXVllQlov22EHpBc8Klb2cBSU5sM 2GlhJ0iiMfH0lvOE= X-Received: by 2002:a5d:4281:: with SMTP id k1mr4197935wrq.374.1617203178557; Wed, 31 Mar 2021 08:06:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw0c0EekwhWdf8bUSNXbJsN8J8ub0016HUPqtJZhGfGnYNmTmw9OET1chcMO8r7mT0J1+4Fzg== X-Received: by 2002:a5d:4281:: with SMTP id k1mr4197917wrq.374.1617203178378; Wed, 31 Mar 2021 08:06:18 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id e8sm4490559wme.14.2021.03.31.08.06.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 08:06:16 -0700 (PDT) Subject: Re: [PATCH] configure: Do not use default_feature for EXESUF To: mrezanin@redhat.com, qemu-devel@nongnu.org References: <20210331081845.105089-1-mrezanin@redhat.com> From: Paolo Bonzini Message-ID: <8187ce64-4060-5a3c-8aee-af69f48584c0@redhat.com> Date: Wed, 31 Mar 2021 17:06:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210331081845.105089-1-mrezanin@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=pbonzini@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Alex_Benn=c3=a9e?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 31/03/21 10:18, mrezanin@redhat.com wrote: > From: Miroslav Rezanina > > Commit "c87ea11631 configure: add --without-default-features" use > default_feature to set default values for configure option. This value > is used for EXESUF too. > > However, EXESUF is not option to be tested, it is just append to any > binary name so using --without-default-features set EXESUF to "n"o and > all binaries using it has form no (e.g. qemu-imgno). > > This is not expected behavior as disabling features should not cause > generating different binary names. > > Reverting back to setting EXESUF to empty value unless needed otherwise. > > Signed-off-by: Miroslav Rezanina > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 535e6a9269..8275df1506 100755 > --- a/configure > +++ b/configure > @@ -365,7 +365,7 @@ tcg_interpreter="false" > bigendian="no" > mingw32="no" > gcov="no" > -EXESUF="$default_feature" > +EXESUF="" > HOST_DSOSUF=".so" > modules="no" > module_upgrades="no" > Queued, thanks. Paolo