From: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
To: Peter Xu <peterx@redhat.com>
Cc: jasowang@redhat.com, qemu-devel@nongnu.org, leiyang@redhat.com,
steven.sistare@oracle.com, yc-core@yandex-team.ru,
mst@redhat.com, farosas@suse.de, eblake@redhat.com,
armbru@redhat.com, thuth@redhat.com, philmd@linaro.org,
berrange@redhat.com
Subject: Re: [PATCH v3 6/9] virtio-net: support local tap migration
Date: Mon, 8 Sep 2025 19:48:32 +0300 [thread overview]
Message-ID: <81a31fa8-a3ec-43d5-abbc-93d1716d37dd@yandex-team.ru> (raw)
In-Reply-To: <aL75seOzauBDqk5j@x1.local>
On 08.09.25 18:43, Peter Xu wrote:
> On Fri, Sep 05, 2025 at 04:50:36PM +0300, Vladimir Sementsov-Ogievskiy wrote:
>> @@ -3525,6 +3609,15 @@ static const VMStateDescription vmstate_virtio_net_device = {
>> * but based on the uint.
>> */
>> VMSTATE_BUFFER_POINTER_UNSAFE(vlans, VirtIONet, 0, MAX_VLAN >> 3),
>> + {
>> + .name = "tap",
>> + .info = &(const VMStateInfo) {
>> + .name = "virtio-net vhost-user backend state",
>
> Just randomly spot this line; likely we need s/vhost-user/tap/..
>
Of-course
> But of course it'll be much better if this can be a subsection, as
> commented previous..
>
Will do.
>> + .get = virtio_net_tap_load,
>> + .put = virtio_net_tap_save,
>> + },
>> + .field_exists = virtio_net_is_tap_local,
>> + },
>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2025-09-08 16:49 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 13:50 [PATCH v3 0/9] virtio-net: live-TAP local migration Vladimir Sementsov-Ogievskiy
2025-09-05 13:50 ` [PATCH v3 1/9] net/tap: add some trace points Vladimir Sementsov-Ogievskiy
2025-09-05 13:50 ` [PATCH v3 2/9] net/tap: keep exit notifier only when downscript set Vladimir Sementsov-Ogievskiy
2025-09-05 13:50 ` [PATCH v3 3/9] net/tap: refactor net_tap_setup_vhost() Vladimir Sementsov-Ogievskiy
2025-09-05 13:50 ` [PATCH v3 4/9] qapi: add interface for local TAP migration Vladimir Sementsov-Ogievskiy
2025-09-08 15:35 ` Peter Xu
2025-09-08 16:38 ` Vladimir Sementsov-Ogievskiy
2025-09-08 18:47 ` Peter Xu
2025-09-09 7:40 ` Vladimir Sementsov-Ogievskiy
2025-09-05 13:50 ` [PATCH v3 5/9] net/tap: implement interfaces for local migration Vladimir Sementsov-Ogievskiy
2025-09-08 15:42 ` Peter Xu
2025-09-08 16:48 ` Vladimir Sementsov-Ogievskiy
2025-09-08 20:01 ` Peter Xu
2025-09-09 7:44 ` Vladimir Sementsov-Ogievskiy
2025-09-09 14:56 ` Peter Xu
2025-09-09 15:08 ` Vladimir Sementsov-Ogievskiy
2025-09-05 13:50 ` [PATCH v3 6/9] virtio-net: support local tap migration Vladimir Sementsov-Ogievskiy
2025-09-08 15:43 ` Peter Xu
2025-09-08 16:48 ` Vladimir Sementsov-Ogievskiy [this message]
2025-09-05 13:50 ` [PATCH v3 7/9] tests/functional: exec_command_and_wait_for_pattern: add vm arg Vladimir Sementsov-Ogievskiy
2025-09-09 14:03 ` Thomas Huth
2025-09-09 14:09 ` Vladimir Sementsov-Ogievskiy
2025-09-05 13:50 ` [PATCH v3 8/9] tests/functional: add skipUnlessPasswordlessSudo() decorator Vladimir Sementsov-Ogievskiy
2025-09-08 15:49 ` Daniel P. Berrangé
2025-09-05 13:50 ` [PATCH v3 9/9] tests/functional: add test_x86_64_tap_fd_migration Vladimir Sementsov-Ogievskiy
2025-09-08 15:58 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81a31fa8-a3ec-43d5-abbc-93d1716d37dd@yandex-team.ru \
--to=vsementsov@yandex-team.ru \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=farosas@suse.de \
--cc=jasowang@redhat.com \
--cc=leiyang@redhat.com \
--cc=mst@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=steven.sistare@oracle.com \
--cc=thuth@redhat.com \
--cc=yc-core@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).