From: Richard Henderson <richard.henderson@linaro.org>
To: Xiaojuan Yang <yangxiaojuan@loongson.cn>, qemu-devel@nongnu.org
Cc: gaosong@loongson.cn, maobibo@loongson.cn,
mark.cave-ayland@ilande.co.uk, mst@redhat.com,
imammedo@redhat.com, ani@anisinha.ca, f4bug@amsat.org,
peter.maydell@linaro.org
Subject: Re: [PATCH v1] target/loongarch/cpu: Fix cpucfg default value
Date: Tue, 19 Jul 2022 12:32:33 +0530 [thread overview]
Message-ID: <81a6374e-dd14-6e74-dd6a-53f8d4fd4db0@linaro.org> (raw)
In-Reply-To: <20220715064829.1521482-1-yangxiaojuan@loongson.cn>
On 7/15/22 12:18, Xiaojuan Yang wrote:
> We should config cpucfg[20] to set value for the scache's ways, sets,
> and size arguments when loongarch cpu init. However, the old code
> wirte 'sets argument' twice, so we change one of them to 'size argument'.
>
> Signed-off-by: Xiaojuan Yang <yangxiaojuan@loongson.cn>
Queued.
r~
> ---
> target/loongarch/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c
> index 89ea971cde..4cfce8c9d2 100644
> --- a/target/loongarch/cpu.c
> +++ b/target/loongarch/cpu.c
> @@ -406,7 +406,7 @@ static void loongarch_la464_initfn(Object *obj)
> data = 0;
> data = FIELD_DP32(data, CPUCFG20, L3IU_WAYS, 15);
> data = FIELD_DP32(data, CPUCFG20, L3IU_SETS, 14);
> - data = FIELD_DP32(data, CPUCFG20, L3IU_SETS, 6);
> + data = FIELD_DP32(data, CPUCFG20, L3IU_SIZE, 6);
> env->cpucfg[20] = data;
>
> env->CSR_ASID = FIELD_DP64(0, CSR_ASID, ASIDBITS, 0xa);
prev parent reply other threads:[~2022-07-19 7:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 6:48 [PATCH v1] target/loongarch/cpu: Fix cpucfg default value Xiaojuan Yang
2022-07-19 5:35 ` Richard Henderson
2022-07-19 7:02 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81a6374e-dd14-6e74-dd6a-53f8d4fd4db0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ani@anisinha.ca \
--cc=f4bug@amsat.org \
--cc=gaosong@loongson.cn \
--cc=imammedo@redhat.com \
--cc=maobibo@loongson.cn \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yangxiaojuan@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).