qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: alex.bennee@linaro.org
Subject: Re: [Qemu-devel] [PATCH v7 04/15] Makefile: Rules for docker testing
Date: Wed, 1 Jun 2016 10:17:01 +0200	[thread overview]
Message-ID: <81b2ec3b-052f-ee44-2d82-d309d21cf3a6@redhat.com> (raw)
In-Reply-To: <1464755128-32490-5-git-send-email-famz@redhat.com>



On 01/06/2016 06:25, Fam Zheng wrote:
> +CUR_TIME := $(shell date +%Y-%m-%d-%H.%M.%S.$$$$)
> +# Makes the definition constant after the first expansion
> +DOCKER_SRC_COPY = $(eval DOCKER_SRC_COPY := /tmp/docker-src.$(CUR_TIME))$(DOCKER_SRC_COPY)
> +
> +$(DOCKER_SRC_COPY):
> +	@mkdir $@
> +	$(call make-archive-maybe, $(SRC_PATH), $@/qemu.tgz)
> +	$(call make-archive-maybe, $(SRC_PATH)/dtc, $@/dtc.tgz)
> +	$(call make-archive-maybe, $(SRC_PATH)/pixman, $@/pixman.tgz)
> +	$(call quiet-command, cp $(SRC_PATH)/tests/docker/run $@/run, \
> +		"  COPY RUNNER")
> +
> +docker-qemu-src: $(DOCKER_SRC_COPY)

Do not use /tmp, instead place it under the current directory.

You can do the change and send a pull request! :)

Paolo

  reply	other threads:[~2016-06-01  8:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-01  4:25 [Qemu-devel] [PATCH v7 00/15] tests: Introducing docker tests Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 01/15] tests: Add utilities for docker testing Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 02/15] rules.mak: Add "COMMA" constant Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 03/15] Makefile: Always include rules.mak Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 04/15] Makefile: Rules for docker testing Fam Zheng
2016-06-01  8:17   ` Paolo Bonzini [this message]
2016-06-01  8:18   ` Paolo Bonzini
2016-06-01  8:59     ` Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 05/15] docker: Add images Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 06/15] docker: Add test runner Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 07/15] docker: Add common.rc Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 08/15] docker: Add quick test Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 09/15] docker: Add full test Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 10/15] docker: Add clang test Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 11/15] docker: Add mingw test Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 12/15] docker: Add travis tool Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 13/15] docs: Add text for tests/docker in build-system.txt Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 14/15] docker: Add EXTRA_CONFIGURE_OPTS Fam Zheng
2016-06-01  4:25 ` [Qemu-devel] [PATCH v7 15/15] MAINTAINERS: Add tests/docker Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81b2ec3b-052f-ee44-2d82-d309d21cf3a6@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).