From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33656) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7j5y-0003UL-Ub for qemu-devel@nongnu.org; Tue, 31 May 2016 08:48:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7j5s-00084p-VW for qemu-devel@nongnu.org; Tue, 31 May 2016 08:48:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53711) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7j5s-00084i-Pa for qemu-devel@nongnu.org; Tue, 31 May 2016 08:48:24 -0400 References: <20160527135437.20474-1-famz@redhat.com> <20160527135437.20474-5-famz@redhat.com> <20160531110058.GA24019@ad.usersys.redhat.com> <56a9a421-be5a-2e81-c4d2-aa1d41219ff4@redhat.com> <20160531124002.GB25364@ad.usersys.redhat.com> From: Paolo Bonzini Message-ID: <81bebb8b-25f8-26de-a3b5-d1f800534b46@redhat.com> Date: Tue, 31 May 2016 14:48:20 +0200 MIME-Version: 1.0 In-Reply-To: <20160531124002.GB25364@ad.usersys.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 04/15] Makefile: Rules for docker testing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, =?UTF-8?Q?Alex_Benn=c3=a9e?= On 31/05/2016 14:40, Fam Zheng wrote: > > I'm still a bit undecided about the pollution introduced by > > tests/docker/Makefile.include, but I guess that's okay. > > I think it's also okay to switch to "make -C tests/docker" for docker targets > (so "make docker" becomes "make -C tests/docker help"), this way the top > Makefile is not touched. That would be a bit harder to discover. Go ahead with your current solution. Perhaps rename SRC_COPY to DOCKER_SRC_COPY? Thanks, Paolo