qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: "Thomas Huth" <thuth@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-devel@nongnu.org,
	"David Gibson" <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 1/2] roms/u-boot: Bump ppce500 u-boot to v2021.07 to add eTSEC support
Date: Tue, 6 Jul 2021 09:41:44 +0200	[thread overview]
Message-ID: <81f41bef-454f-928f-0f93-0deef3ab7716@redhat.com> (raw)
In-Reply-To: <20210706043124.1871866-1-bmeng.cn@gmail.com>

Hi Bin,

On 7/6/21 6:31 AM, Bin Meng wrote:
> Update the QEMU shipped u-boot.e500 image built from U-Boot mainline
> v2021.07 release, which added eTSEC support to the QEMU ppce500 target,
> via the following U-Boot series:
> 
>   http://patchwork.ozlabs.org/project/uboot/list/?series=233875&state=*
> 
> The cross-compilation toolchain used to build the U-Boot image is:
> https://mirrors.edge.kernel.org/pub/tools/crosstool/files/bin/x86_64/10.1.0/x86_64-gcc-10.1.0-nolibc-powerpc-linux.tar.xz

Ideally the process to update a firmware blob is (*):

- Add a CI job (as you did for .gitlab-ci.d/opensbi.yml)
- Commit the submodule new hash including "git shortlog current..new"
  in description
- Run the CI, download the almost-reproducible blob
- Test the blob locally
- Amend to the previous commit the CI blob

Since soft freeze is in 1 week, you might won't have enough time
to add a CI job, so this current patch is acceptable, but please
include the "git shortlog current..new" output.

Regards,

Phil.

(*) Yes we should document this somewhere. Wiki or docs?

> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> ---
> 
> Please pull the full contents (the u-boot.e500 binary) from
> https://github.com/lbmeng/qemu, branch qemu-ppc.
> 
>  pc-bios/u-boot.e500 | Bin 406920 -> 421720 bytes
>  roms/u-boot         |   2 +-
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pc-bios/u-boot.e500 b/pc-bios/u-boot.e500
> index d2e29f81d6..8e635c8a5c 100644
> Binary files a/pc-bios/u-boot.e500 and b/pc-bios/u-boot.e500 differ
> diff --git a/roms/u-boot b/roms/u-boot
> index b46dd116ce..840658b093 160000
> --- a/roms/u-boot
> +++ b/roms/u-boot
> @@ -1 +1 @@
> -Subproject commit b46dd116ce03e235f2a7d4843c6278e1da44b5e1
> +Subproject commit 840658b093976390e9537724f802281c9c8439f5
> 



  parent reply	other threads:[~2021-07-06  7:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-06  4:31 [PATCH 1/2] roms/u-boot: Bump ppce500 u-boot to v2021.07 to add eTSEC support Bin Meng
2021-07-06  4:31 ` [PATCH 2/2] docs/system: ppc: Update ppce500 documentation with " Bin Meng
2021-07-08  0:58   ` David Gibson
2021-07-08  1:22     ` Bin Meng
2021-07-08  2:40       ` David Gibson
2021-07-06  7:41 ` Philippe Mathieu-Daudé [this message]
2021-07-06  7:51   ` [PATCH 1/2] roms/u-boot: Bump ppce500 u-boot to v2021.07 to add " Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81f41bef-454f-928f-0f93-0deef3ab7716@redhat.com \
    --to=philmd@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=bmeng.cn@gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).