qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Mike Frysinger <vapier@gentoo.org>, richard.henderson@linaro.org
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [PATCH] tcg: drop unused tcg_temp_free define
Date: Sun, 15 Oct 2023 17:59:11 +0200	[thread overview]
Message-ID: <81fbd234-0280-61ad-32a4-d785a4640f21@linaro.org> (raw)
In-Reply-To: <20231015010046.16020-1-vapier@gentoo.org>

On 15/10/23 03:00, Mike Frysinger wrote:
> Use of the API was removed a while back, but the define wasn't.

The cleanup started in commit 47f7313d81 ("tcg: Create
tcg/tcg-temp-internal.h") and the last use got removed
in d5920b7280 ("tcg: Remove TCGv from tcg_gen_qemu_{ld,st}_*").

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>   include/tcg/tcg-op.h | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/include/tcg/tcg-op.h b/include/tcg/tcg-op.h
> index 80cfcf8104b6..3ead59e4594d 100644
> --- a/include/tcg/tcg-op.h
> +++ b/include/tcg/tcg-op.h
> @@ -52,7 +52,6 @@ static inline void tcg_gen_insn_start(target_ulong pc, target_ulong a1,
>   typedef TCGv_i32 TCGv;
>   #define tcg_temp_new() tcg_temp_new_i32()
>   #define tcg_global_mem_new tcg_global_mem_new_i32
> -#define tcg_temp_free tcg_temp_free_i32
>   #define tcgv_tl_temp tcgv_i32_temp
>   #define tcg_gen_qemu_ld_tl tcg_gen_qemu_ld_i32
>   #define tcg_gen_qemu_st_tl tcg_gen_qemu_st_i32
> @@ -60,7 +59,6 @@ typedef TCGv_i32 TCGv;
>   typedef TCGv_i64 TCGv;
>   #define tcg_temp_new() tcg_temp_new_i64()
>   #define tcg_global_mem_new tcg_global_mem_new_i64
> -#define tcg_temp_free tcg_temp_free_i64
>   #define tcgv_tl_temp tcgv_i64_temp
>   #define tcg_gen_qemu_ld_tl tcg_gen_qemu_ld_i64
>   #define tcg_gen_qemu_st_tl tcg_gen_qemu_st_i64



  reply	other threads:[~2023-10-15 15:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-15  1:00 [PATCH] tcg: drop unused tcg_temp_free define Mike Frysinger
2023-10-15 15:59 ` Philippe Mathieu-Daudé [this message]
2023-10-15 18:33 ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=81fbd234-0280-61ad-32a4-d785a4640f21@linaro.org \
    --to=philmd@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).